From 7a38e12ed094aaca637f68ecee4099f57a8733f7 Mon Sep 17 00:00:00 2001 From: Sebastian Keller Date: Sun, 19 May 2024 19:53:37 +0200 Subject: [PATCH] egl: Don't free source error after propagating it local_error in meta_egl_query_device_string() is using g_autoptr, meaning that it was getting freed after g_propagate_error(). This then would result in error->message becoming invalid, causing crashes when logging the error message later on. Fixes: 8234f5bc7 ("egl: Return success status from meta_egl_query_device_string") Part-of: --- src/backends/meta-egl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backends/meta-egl.c b/src/backends/meta-egl.c index 2f8247b3a..cc023f705 100644 --- a/src/backends/meta-egl.c +++ b/src/backends/meta-egl.c @@ -827,7 +827,7 @@ meta_egl_query_device_string (MetaEgl *egl, check_egl_error (&local_error); if (local_error) { - g_propagate_error (error, local_error); + g_propagate_error (error, g_steal_pointer (&local_error)); return FALSE; } }