From 679d2fb4e069ac7fbb021dda24f97fdc875274fb Mon Sep 17 00:00:00 2001 From: Sebastian Keller Date: Tue, 21 Mar 2023 00:52:39 +0100 Subject: [PATCH] build: Don't disable checks in release builds Both Clutter and Cogl use g_return(_val)_if_fail() to safeguard introspected API. Release builds were dropping these checks, which could result in a much more crashy experience, especially when considering extensions, but also due to bugs in the shell code itself. This won't affect any major distro, because they all use "plain" builds. Part-of: --- clutter/meson.build | 1 - cogl/meson.build | 1 - 2 files changed, 2 deletions(-) diff --git a/clutter/meson.build b/clutter/meson.build index 918153ee4..07256486b 100644 --- a/clutter/meson.build +++ b/clutter/meson.build @@ -21,7 +21,6 @@ if get_option('debug') elif buildtype != 'plain' clutter_debug_c_args += [ '-DG_DISABLE_ASSERT', - '-DG_DISABLE_CHECKS', '-DG_DISABLE_CAST_CHECKS', ] endif diff --git a/cogl/meson.build b/cogl/meson.build index e73f1a8f9..277dfaba1 100644 --- a/cogl/meson.build +++ b/cogl/meson.build @@ -106,7 +106,6 @@ if get_option('debug') ] elif buildtype != 'plain' cogl_debug_c_args += [ - '-DG_DISABLE_CHECKS', '-DG_DISABLE_CAST_CHECKS' ] endif