From 6628acb59c697d6317b87dddd44a26ecea698ba3 Mon Sep 17 00:00:00 2001 From: Havoc Pennington Date: Sat, 11 Oct 2003 04:27:06 +0000 Subject: [PATCH] initialize display->grab_have_pointer to FALSE, previously I think you 2003-10-11 Havoc Pennington * src/display.c (meta_display_begin_grab_op): initialize display->grab_have_pointer to FALSE, previously I think you could get a case where we didn't have the grab and thought we did. Bugs were reported with this happening. Of course we still have the "why did the grab fail" problem, but it should be less noticeable with this fixed. --- ChangeLog | 9 +++++++++ src/display.c | 2 ++ 2 files changed, 11 insertions(+) diff --git a/ChangeLog b/ChangeLog index e5033c868..ab710bfa8 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,12 @@ +2003-10-11 Havoc Pennington + + * src/display.c (meta_display_begin_grab_op): initialize + display->grab_have_pointer to FALSE, previously I think you could + get a case where we didn't have the grab and thought we did. + Bugs were reported with this happening. Of course we still have + the "why did the grab fail" problem, but it should be less + noticeable with this fixed. + 2003-10-06 Rob Adams * src/constraints.c (constraint_onscreen_*_func): disable onscreen diff --git a/src/display.c b/src/display.c index 29a000e00..c09867692 100644 --- a/src/display.c +++ b/src/display.c @@ -2818,6 +2818,8 @@ meta_display_begin_grab_op (MetaDisplay *display, grab_xwindow = window->frame ? window->frame->xwindow : window->xwindow; else grab_xwindow = screen->xroot; + + display->grab_have_pointer = FALSE; if (pointer_already_grabbed) display->grab_have_pointer = TRUE;