brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

window-drag: Check whether window is set when hiding tile preview

Browse Source 
In the case where we early-out from meta_window_drag_begin(), the
effective_drag_window might not be set yet. In this case, we might finalize
the object before effective_drag_window is set, leading to a NULL pointer
when accessing window->display in hide_tile_preview().

To avoid that crash, add a check whether the window is set already. If no
window is set, we can just skip hiding the preview anyway.

Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2858>
This commit is contained in:
Jonas Dreßler 2023-02-02 13:55:08 +01:00 committed by Marge Bot
parent 36ae716e4d
commit 65b93e1d45
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/compositor/meta-window-drag.c
View File

@ -165,7 +165,8 @@ hide_tile_preview (MetaWindowDrag *window_drag)
window_drag->preview_tile_mode = META_TILE_NONE;
window = meta_window_drag_get_window (window_drag);
meta_compositor_hide_tile_preview (window->display->compositor);
if (window)
meta_compositor_hide_tile_preview (window->display->compositor);
}
static void