brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

stack-tracker: Improve documentation why we need to filter x11 windows

Browse Source 
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3732>
This commit is contained in:
Marco Trevisan (Treviño) 2024-05-04 04:46:01 +02:00 committed by Marge Bot
parent c202662ca3
commit 5b1c0c2123
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/core/stack-tracker.c
View File

@ -1078,7 +1078,14 @@ meta_stack_tracker_sync_stack (MetaStackTracker *tracker)
/* When mapping back from xwindow to MetaWindow we have to be a bit careful; /* When mapping back from xwindow to MetaWindow we have to be a bit careful;
* children of the root could include unmapped windows created by toolkits * children of the root could include unmapped windows created by toolkits
* for internal purposes, including ones that we have registered in our * for internal purposes, including ones that we have registered in our
* XID => window table. (Wine uses a toplevel for _NET_WM_USER_TIME_WINDOW; * XID => window table (such as user time or frame windows) and we
* don't want to duplicate them not to break the compositor assumption
* that the list we pass contains unique IDs (leading to crashes due
* to wrong removals on destruction).
* Only include the unframed windows whose XID matches the one we're
* handling or we'd end up including all the internal windows we've
* associated to the same meta window, such as the user time windows.
* (Wine uses a toplevel for _NET_WM_USER_TIME_WINDOW;
* see window-prop.c:reload_net_wm_user_time_window() for registration.) * see window-prop.c:reload_net_wm_user_time_window() for registration.)
*/ */
frame = meta_window ? meta_window_x11_get_frame (meta_window) : NULL; frame = meta_window ? meta_window_x11_get_frame (meta_window) : NULL;