brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

stack: don't deref freed mem in _cogl_memory_stack_free

Browse Source 
This fixes _cogl_memory_stack_free to ensure we don't dereference freed
memory as we iterate the sub-stacks to free them.

Reviewed-by: Neil Roberts <neil@linux.intel.com>

(cherry picked from commit 1d27fedef9c599aa9976b809f18e0da1913cec26)
This commit is contained in:
Robert Bragg 2012-06-20 18:04:25 +01:00
parent df51574116
commit 56382435fa
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
cogl/cogl-memory-stack.c
View File

@ -177,10 +177,9 @@ _cogl_memory_stack_free (CoglMemoryStack *stack)
{ {
CoglMemorySubStack *sub_stack; CoglMemorySubStack *sub_stack;
for (sub_stack = stack->sub_stacks.tqh_first; while ((sub_stack = COGL_TAILQ_FIRST (&stack->sub_stacks)))
sub_stack;
sub_stack = sub_stack->list_node.tqe_next)
{ {
COGL_TAILQ_REMOVE (&stack->sub_stacks, sub_stack, list_node);
_cogl_memory_sub_stack_free (sub_stack); _cogl_memory_sub_stack_free (sub_stack);
} }