From 54b5d076820cce3f69a699b34ca810204651bcc0 Mon Sep 17 00:00:00 2001 From: Emmanuele Bassi Date: Mon, 8 Jun 2009 02:22:26 +0100 Subject: [PATCH] [build] Add AS_COMPILER_FLAGS Use the AS_COMPILER_FLAGS to check whether the maintainer compiler flags we use are supported; this should fail gracefully and only use the ones that the compiler actually understands. Fixes bug: http://bugzilla.openedhand.com/show_bug.cgi?id=1639 --- build/autotools/as-compiler-flag.m4 | 62 +++++++++++++++++++++++++++++ configure.ac | 5 ++- 2 files changed, 66 insertions(+), 1 deletion(-) create mode 100644 build/autotools/as-compiler-flag.m4 diff --git a/build/autotools/as-compiler-flag.m4 b/build/autotools/as-compiler-flag.m4 new file mode 100644 index 000000000..0f660cf07 --- /dev/null +++ b/build/autotools/as-compiler-flag.m4 @@ -0,0 +1,62 @@ +dnl as-compiler-flag.m4 0.1.0 + +dnl autostars m4 macro for detection of compiler flags + +dnl David Schleef + +dnl $Id: as-compiler-flag.m4,v 1.1 2005/12/15 23:35:19 ds Exp $ + +dnl AS_COMPILER_FLAG(CFLAGS, ACTION-IF-ACCEPTED, [ACTION-IF-NOT-ACCEPTED]) +dnl Tries to compile with the given CFLAGS. +dnl Runs ACTION-IF-ACCEPTED if the compiler can compile with the flags, +dnl and ACTION-IF-NOT-ACCEPTED otherwise. + +AC_DEFUN([AS_COMPILER_FLAG], +[ + AC_MSG_CHECKING([to see if compiler understands $1]) + + save_CFLAGS="$CFLAGS" + CFLAGS="$CFLAGS $1" + + AC_TRY_COMPILE([ ], [], [flag_ok=yes], [flag_ok=no]) + CFLAGS="$save_CFLAGS" + + if test "X$flag_ok" = Xyes ; then + m4_ifvaln([$2],[$2]) + true + else + m4_ifvaln([$3],[$3]) + true + fi + AC_MSG_RESULT([$flag_ok]) +]) + +dnl AS_COMPILER_FLAGS(VAR, FLAGS) +dnl Tries to compile with the given CFLAGS. + +AC_DEFUN([AS_COMPILER_FLAGS], +[ + list=$2 + flags_supported="" + flags_unsupported="" + AC_MSG_CHECKING([for supported compiler flags]) + for each in $list + do + save_CFLAGS="$CFLAGS" + CFLAGS="$CFLAGS $each" + AC_TRY_COMPILE([ ], [], [flag_ok=yes], [flag_ok=no]) + CFLAGS="$save_CFLAGS" + + if test "X$flag_ok" = Xyes ; then + flags_supported="$flags_supported $each" + else + flags_unsupported="$flags_unsupported $each" + fi + done + AC_MSG_RESULT([$flags_supported]) + if test "X$flags_unsupported" != X ; then + AC_MSG_WARN([unsupported compiler flags: $flags_unsupported]) + fi + $1="$$1 $flags_supported" +]) + diff --git a/configure.ac b/configure.ac index 0e49ec658..f75509874 100644 --- a/configure.ac +++ b/configure.ac @@ -679,7 +679,10 @@ AC_ARG_ENABLE([maintainer-flags], AS_IF([test "x$enable_maintainer_flags" = "xyes" && test "x$GCC" = "xyes"], [ - MAINTAINER_CFLAGS="-Wall -Wshadow -Wcast-align -Wno-uninitialized -Wno-strict-aliasing -Wempty-body -Wformat-security -Winit-self" + AS_COMPILER_FLAGS([MAINTAINER_CFLAGS], + ["-Wall -Wshadow -Wcast-align -Wno-uninitialized + -Wno-strict-aliasing -Wempty-body -Wformat-security + -Winit-self"]) ] )