brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

window: Make sure not to respond to input events on OR windows

Browse Source 
This can happen since we select for events on the root window, and
clients themselves might not select for input, meaning the X server
will bubble up. Just do nothing and ignore the event in this case.

This should hopefully fix some of the

Window manager warning: Log level 8: meta_window_raise: assertion '!window->override_redirect' failed
Window manager warning: Log level 8: meta_window_focus: assertion '!window->override_redirect' failed

spam that people have been seeing.
This commit is contained in:
Jasper St. Pierre 2014-06-02 15:37:43 -04:00
parent 048f035d30
commit 53425fa721
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/core/window.c
View File

@ -7784,6 +7784,15 @@ meta_window_handle_ungrabbed_event (MetaWindow *window,
if (display->grab_op != META_GRAB_OP_NONE) if (display->grab_op != META_GRAB_OP_NONE)
return FALSE; return FALSE;
/* Some windows might not ask for input, in which case we might be here
* because we selected for ButtonPress on the root window. In that case,
* we have to take special care not to act for an override-redirect window.
*
* Consume the event in this case, though, since we don't want it passed
* to the compositor or UI. */
if (window->override_redirect)
return TRUE;
/* We have three passive button grabs: /* We have three passive button grabs:
* - on any button, without modifiers => focuses and maybe raises the window * - on any button, without modifiers => focuses and maybe raises the window
* - on resize button, with modifiers => start an interactive resizing * - on resize button, with modifiers => start an interactive resizing