brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

stage: Make some cursor overlay function names more obvious

Browse Source 
Overlays are always cursors, and "redraw overlay" doesn't communicate
that. Add "cursor" or "cursor overlay" to some functions to make it a
bit more obvious in a couple of places.

Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/4066>
This commit is contained in:
Jonas Ådahl 2024-11-11 23:31:46 +01:00 committed by Marge Bot
parent 67995f2730
commit 52aa84b3c3
1 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/backends/meta-stage.c
View File

@ -350,9 +350,9 @@ meta_stage_new (MetaBackend *backend)
} }
static void static void
queue_redraw_clutter_rect (MetaStage *stage, queue_cursor_overlay_redraw_clutter_rect (MetaStage *stage,
MetaOverlay *overlay, MetaOverlay *overlay,
graphene_rect_t *rect) graphene_rect_t *rect)
{ {
MtkRectangle clip = { MtkRectangle clip = {
.x = (int) floorf (rect->origin.x), .x = (int) floorf (rect->origin.x),
@ -393,19 +393,25 @@ queue_redraw_clutter_rect (MetaStage *stage,
} }
static void static void
queue_redraw_for_overlay (MetaStage *stage, queue_redraw_for_cursor_overlay (MetaStage *stage,
MetaOverlay *overlay) MetaOverlay *overlay)
{ {
/* Clear the location the overlay was at before, if we need to. */ /* Clear the location the overlay was at before, if we need to. */
if (overlay->previous_is_valid) if (overlay->previous_is_valid)
{ {
queue_redraw_clutter_rect (stage, overlay, &overlay->previous_rect); queue_cursor_overlay_redraw_clutter_rect (stage,
overlay,
&overlay->previous_rect);
overlay->previous_is_valid = FALSE; overlay->previous_is_valid = FALSE;
} }
/* Draw the overlay at the new position */ /* Draw the overlay at the new position */
if (overlay->is_visible && overlay->texture) if (overlay->is_visible && overlay->texture)
queue_redraw_clutter_rect (stage, overlay, &overlay->current_rect); {
queue_cursor_overlay_redraw_clutter_rect (stage,
overlay,
&overlay->current_rect);
}
} }
MetaOverlay * MetaOverlay *
@ -441,7 +447,7 @@ meta_stage_update_cursor_overlay (MetaStage *stage,
MtkMonitorTransform buffer_transform) MtkMonitorTransform buffer_transform)
{ {
meta_overlay_set (overlay, texture, rect, buffer_transform); meta_overlay_set (overlay, texture, rect, buffer_transform);
queue_redraw_for_overlay (stage, overlay); queue_redraw_for_cursor_overlay (stage, overlay);
} }
void void
@ -452,7 +458,7 @@ meta_overlay_set_visible (MetaOverlay *overlay,
return; return;
overlay->is_visible = is_visible; overlay->is_visible = is_visible;
queue_redraw_for_overlay (overlay->stage, overlay); queue_redraw_for_cursor_overlay (overlay->stage, overlay);
} }
MetaStageWatch * MetaStageWatch *