From 526bc34bba20b5f8d3055f2fb668a36a21357443 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Wed, 15 Jun 2011 20:58:12 +0200 Subject: [PATCH] frames: Always start grab operation on left click When left-clicking the frame border with the titlebar being off-screen, rather than starting the expected grab operation the window menu was popped up. This behavior is pretty confusing, especially since the menu button was removed from the default layout, making right-clicking the only way to get to the window menu. https://bugzilla.gnome.org/show_bug.cgi?id=652369 --- src/ui/frames.c | 33 ++++++++++----------------------- 1 file changed, 10 insertions(+), 23 deletions(-) diff --git a/src/ui/frames.c b/src/ui/frames.c index 9f0126cfd..754475990 100644 --- a/src/ui/frames.c +++ b/src/ui/frames.c @@ -1710,7 +1710,6 @@ meta_frames_button_press_event (GtkWidget *widget, control == META_FRAME_CONTROL_RESIZE_W)) { MetaGrabOp op; - gboolean titlebar_is_onscreen; op = META_GRAB_OP_NONE; @@ -1745,28 +1744,16 @@ meta_frames_button_press_event (GtkWidget *widget, break; } - meta_core_get (display, frame->xwindow, - META_CORE_IS_TITLEBAR_ONSCREEN, &titlebar_is_onscreen, - META_CORE_GET_END); - - if (!titlebar_is_onscreen) - meta_core_show_window_menu (display, - frame->xwindow, - event->x_root, - event->y_root, - event->button, - event->time); - else - meta_core_begin_grab_op (display, - frame->xwindow, - op, - TRUE, - TRUE, - event->button, - 0, - event->time, - event->x_root, - event->y_root); + meta_core_begin_grab_op (display, + frame->xwindow, + op, + TRUE, + TRUE, + event->button, + 0, + event->time, + event->x_root, + event->y_root); } else if (control == META_FRAME_CONTROL_TITLE && event->button == 1)