From 4ad2d1a04814ecdf141e81fac3db588f52f40996 Mon Sep 17 00:00:00 2001 From: Havoc Pennington Date: Sun, 15 Dec 2002 18:55:08 +0000 Subject: [PATCH] make the warning about strange property contents blame the application and 2002-12-15 Havoc Pennington * src/xprops.c (validate_or_free_results): make the warning about strange property contents blame the application and explain how to use xprop to diagnose which app is causing the problem. --- ChangeLog | 6 ++++++ src/xprops.c | 5 +++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index ba9e2a096..deb3d93aa 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2002-12-15 Havoc Pennington + + * src/xprops.c (validate_or_free_results): make the warning about + strange property contents blame the application and explain how to + use xprop to diagnose which app is causing the problem. + 2002-12-15 Havoc Pennington * src/prefs.c (meta_prefs_change_workspace_name): don't pass NULL diff --git a/src/xprops.c b/src/xprops.c index f903b1e60..06ea0e19b 100644 --- a/src/xprops.c +++ b/src/xprops.c @@ -121,13 +121,14 @@ validate_or_free_results (GetPropertyResults *results, prop_name = XGetAtomName (results->display->xdisplay, results->xatom); meta_error_trap_pop (results->display, TRUE); - meta_warning (_("Window 0x%lx has property %s that was expected to have type %s format %d and actually has type %s format %d n_items %d\n"), + meta_warning (_("Window 0x%lx has property %s\nthat was expected to have type %s format %d\nand actually has type %s format %d n_items %d.\nThis is most likely an application bug.\nUse \"xprop -id 0x%lx\" to print all properties on the problematic window.\nThe _NET_WM_NAME or WM_NAME or WM_CLASS properties should identify the application.\n"), results->xwindow, prop_name ? prop_name : "(bad atom)", expected_name ? expected_name : "(bad atom)", expected_format, type_name ? type_name : "(bad atom)", - results->format, (int) results->n_items); + results->format, (int) results->n_items, + results->xwindow); if (type_name) XFree (type_name);