brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

actor: Fix logic error in determining terminal effect for paint volume

Browse Source 
Previously we were checking l->data != NULL || (l->data != NULL &&
l->data != priv->current_effect). This would continue the loop even
if l->data == priv->current_effect, since l->data != NULL, which was
not the intention of that loop.

We also don't need to check that l->data != NULL before checking if
it does not match the current_effect, since we already checked
that current_effect was non-NULL before entering the loop.
This commit is contained in:
Sam Spilsbury 2018-08-29 08:27:16 +08:00 committed by Georges Basile Stavracas Neto
parent b443bd42ac
commit 4270eef16e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clutter/clutter/clutter-actor.c
View File

@ -17485,7 +17485,7 @@ _clutter_actor_get_paint_volume_real (ClutterActor *self,
*/ */
effects = _clutter_meta_group_peek_metas (priv->effects); effects = _clutter_meta_group_peek_metas (priv->effects);
for (l = effects; for (l = effects;
l != NULL || (l != NULL && l->data != priv->current_effect); l != NULL && l->data != priv->current_effect;
l = l->next) l = l->next)
{ {
if (!_clutter_effect_get_paint_volume (l->data, pv)) if (!_clutter_effect_get_paint_volume (l->data, pv))