From 3cf3d5d1c6274c6d9af30303eb9bb7ba9875cc5d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michel=20D=C3=A4nzer?= Date: Mon, 26 Aug 2024 17:00:09 +0200 Subject: [PATCH] kms/crtc: Complain and bail if DRM mode info isn't valid Otherwise meta_calculate_drm_mode_refresh_rate returns 0.0, which results in non-sense refresh_interval_us. https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3982 fixed that happening before. This is intended to catch if it ever happens again. Part-of: --- src/backends/native/meta-kms-crtc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/backends/native/meta-kms-crtc.c b/src/backends/native/meta-kms-crtc.c index 7d4fac75b..ecab769de 100644 --- a/src/backends/native/meta-kms-crtc.c +++ b/src/backends/native/meta-kms-crtc.c @@ -700,6 +700,8 @@ meta_kms_crtc_update_shortterm_max_dispatch_duration (MetaKmsCrtc *crtc, { int64_t refresh_interval_us; + g_return_if_fail (crtc->current_state.is_drm_mode_valid); + /* meta_kms_crtc_determine_deadline doesn't use deadline evasion with VRR */ if (crtc->current_state.vrr.enabled) return;