From 376c0585ef00b3af49f2255860d7591dcfe067d2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michel=20D=C3=A4nzer?= Date: Tue, 26 Nov 2024 12:01:32 +0100 Subject: [PATCH] clutter/stage-view: Clear output_color_state in dispose Fixes leaks: ==1060013== 96 (32 direct, 64 indirect) bytes in 1 blocks are definitely lost in loss record 10,897 of 13,064 ==1060013== at 0x4F81D57: g_type_create_instance (gtype.c:1929) ==1060013== by 0x4F64ABF: g_object_new_internal.part.0 (gobject.c:2606) ==1060013== by 0x4F66ADD: g_object_new_internal (gobject.c:2603) ==1060013== by 0x4F66ADD: g_object_new_with_properties (gobject.c:2769) ==1060013== by 0x4F67A30: g_object_new (gobject.c:2415) ==1060013== by 0x52F7C7B: clutter_color_state_new_full (clutter-color-state.c:339) ==1060013== by 0x4939CD0: update_color_state (meta-color-device.c:725) ==1060013== by 0x4939DDE: meta_color_device_new (meta-color-device.c:759) ==1060013== by 0x493CB7B: update_devices (meta-color-manager.c:205) ==1060013== by 0x493CE65: meta_color_manager_monitors_changed (meta-color-manager.c:264) ==1060013== by 0x49341CB: meta_backend_monitors_changed (meta-backend.c:371) ==1060013== by 0x4969150: meta_monitor_manager_notify_monitors_changed (meta-monitor-manager.c:1235) ==1060013== by 0x496928F: meta_monitor_manager_setup (meta-monitor-manager.c:1273) ==1060013== ==1060013== 96 (32 direct, 64 indirect) bytes in 1 blocks are definitely lost in loss record 10,898 of 13,064 ==1060013== at 0x4F81D57: g_type_create_instance (gtype.c:1929) ==1060013== by 0x4F64ABF: g_object_new_internal.part.0 (gobject.c:2606) ==1060013== by 0x4F66ADD: g_object_new_internal (gobject.c:2603) ==1060013== by 0x4F66ADD: g_object_new_with_properties (gobject.c:2769) ==1060013== by 0x4F67A30: g_object_new (gobject.c:2415) ==1060013== by 0x52F7C7B: clutter_color_state_new_full (clutter-color-state.c:339) ==1060013== by 0x4939CD0: update_color_state (meta-color-device.c:725) ==1060013== by 0x4939DDE: meta_color_device_new (meta-color-device.c:759) ==1060013== by 0x493CB7B: update_devices (meta-color-manager.c:205) ==1060013== by 0x493CE65: meta_color_manager_monitors_changed (meta-color-manager.c:264) ==1060013== by 0x49341CB: meta_backend_monitors_changed (meta-backend.c:371) ==1060013== by 0x4969150: meta_monitor_manager_notify_monitors_changed (meta-monitor-manager.c:1235) ==1060013== by 0x496EA7D: meta_monitor_manager_rebuild (meta-monitor-manager.c:3968) Part-of: --- clutter/clutter/clutter-stage-view.c | 1 + 1 file changed, 1 insertion(+) diff --git a/clutter/clutter/clutter-stage-view.c b/clutter/clutter/clutter-stage-view.c index 2e0137bba..63e24104d 100644 --- a/clutter/clutter/clutter-stage-view.c +++ b/clutter/clutter/clutter-stage-view.c @@ -1335,6 +1335,7 @@ clutter_stage_view_dispose (GObject *object) g_clear_object (&priv->color_state); g_clear_object (&priv->offscreen); g_clear_object (&priv->offscreen_pipeline); + g_clear_object (&priv->output_color_state); g_clear_pointer (&priv->redraw_clip, mtk_region_unref); g_clear_pointer (&priv->accumulated_redraw_clip, mtk_region_unref); g_clear_pointer (&priv->frame_clock, clutter_frame_clock_destroy);