brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

x11: Do not unminimize windows with initial IconicState

Browse Source 
This is a revert of commit be5c2ebc, adapted to this day and age.
While this worked around issues in wine/proton, it did contravene
icccm in the interpretation of initially iconic windows.

Closes: https://gitlab.gnome.org/GNOME/mutter/-/issues/2043
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3001>
This commit is contained in:
Carlos Garnacho 2023-03-01 17:43:24 +01:00 committed by Marge Bot
parent b9a6891910
commit 3218626d7e
1 changed files with 12 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
src/x11/events.c
View File

@ -1528,32 +1528,22 @@ handle_other_xevent (MetaX11Display *x11_display,
window = meta_window_x11_new (display, event->xmaprequest.window, window = meta_window_x11_new (display, event->xmaprequest.window,
FALSE, META_COMP_EFFECT_CREATE); FALSE, META_COMP_EFFECT_CREATE);
/* The window might have initial iconic state, but this is a
* MapRequest, fall through to ensure it is unminimized in
* that case.
*/
} }
else if (frame_was_receiver) else
{ {
break; meta_verbose ("MapRequest on %s mapped = %d minimized = %d",
} window->desc, window->mapped, window->minimized);
/* Double check that creating the MetaWindow succeeded */ if (window->minimized && !frame_was_receiver)
if (window == NULL)
break;
meta_verbose ("MapRequest on %s mapped = %d minimized = %d",
window->desc, window->mapped, window->minimized);
if (window->minimized)
{
meta_window_unminimize (window);
if (window->workspace != workspace_manager->active_workspace)
{ {
meta_verbose ("Changing workspace due to MapRequest mapped = %d minimized = %d", meta_window_unminimize (window);
window->mapped, window->minimized); if (window->workspace != workspace_manager->active_workspace)
meta_window_change_workspace (window, {
workspace_manager->active_workspace); meta_verbose ("Changing workspace due to MapRequest mapped = %d minimized = %d",
window->mapped, window->minimized);
meta_window_change_workspace (window,
workspace_manager->active_workspace);
}
} }
} }
break; break;