brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make meta_* logging utilities not require line break

Browse Source 
Unlike g_* logging utilities, the meta_* counterparts behave like odd
printf() functions. Lets change that so they fit better into how logging
is done everywhere else.

https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1466
This commit is contained in:
Jonas Ådahl
2020-10-02 17:47:22 +02:00
parent dbe44f3a83
commit 313e3e771c
50 changed files with 596 additions and 579 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/core/util.c
View File

@@ -79,7 +79,7 @@ ensure_logfile (void)
if (err != NULL)
{
meta_warning ("Failed to open debug log: %s\n",
meta_warning ("Failed to open debug log: %s",
err->message);
g_error_free (err);
return;
@@ -89,13 +89,13 @@ ensure_logfile (void)
if (logfile == NULL)
{
meta_warning ("Failed to fdopen() log file %s: %s\n",
meta_warning ("Failed to fdopen() log file %s: %s",
filename, strerror (errno));
close (fd);
}
else
{
g_printerr ("Opened log file %s\n", filename);
g_printerr ("Opened log file %s", filename);
}
g_free (filename);
@@ -114,7 +114,7 @@ meta_set_verbose (gboolean setting)
{
#ifndef WITH_VERBOSE_MODE
if (setting)
meta_fatal (_("Mutter was compiled without support for verbose mode\n"));
meta_fatal (_("Mutter was compiled without support for verbose mode"));
#endif
if (setting)
@@ -314,6 +314,7 @@ meta_topic_real_valist (MetaDebugTopic topic,
}
utf8_fputs (str, out);
utf8_fputs ("\n", out);
fflush (out);
@@ -355,6 +356,7 @@ meta_bug (const char *format, ...)
if (no_prefix == 0)
utf8_fputs ("Bug in window manager: ", out);
utf8_fputs (str, out);
utf8_fputs ("\n", out);
fflush (out);
@@ -386,6 +388,7 @@ meta_warning (const char *format, ...)
if (no_prefix == 0)
utf8_fputs ("Window manager warning: ", out);
utf8_fputs (str, out);
utf8_fputs ("\n", out);
fflush (out);
@@ -416,6 +419,7 @@ meta_fatal (const char *format, ...)
if (no_prefix == 0)
utf8_fputs ("Window manager error: ", out);
utf8_fputs (str, out);
utf8_fputs ("\n", out);
fflush (out);
@@ -647,7 +651,7 @@ meta_show_dialog (const char *type,
if (error)
{
meta_warning ("%s\n", error->message);
meta_warning ("%s", error->message);
g_error_free (error);
}