From 31165c2d86ec2ee9cab80d1e189085afc3514d87 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marco=20Trevisan=20=28Trevi=C3=B1o=29?= Date: Wed, 1 May 2024 03:15:51 +0200 Subject: [PATCH] x11/window: Add proper type guard to x11-specific public API calls These functions are specific for X11 windows only so we should check if the passed window is an X11 one, not just a MetaWindow since we're casting to the actual type at later point. Fixes changes part of commit e1e6534eb Part-of: --- src/x11/window-x11.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/x11/window-x11.c b/src/x11/window-x11.c index b87c5072a..2ab109497 100644 --- a/src/x11/window-x11.c +++ b/src/x11/window-x11.c @@ -4439,7 +4439,7 @@ meta_window_x11_get_xwindow (MetaWindow *window) MetaWindowX11 *window_x11; MetaWindowX11Private *priv; - g_return_val_if_fail (META_IS_WINDOW (window), None); + g_return_val_if_fail (META_IS_WINDOW_X11 (window), None); window_x11 = META_WINDOW_X11 (window); priv = meta_window_x11_get_instance_private (window_x11); @@ -4453,7 +4453,7 @@ meta_window_x11_get_xgroup_leader (MetaWindow *window) MetaWindowX11 *window_x11; MetaWindowX11Private *priv; - g_return_val_if_fail (META_IS_WINDOW (window), None); + g_return_val_if_fail (META_IS_WINDOW_X11 (window), None); window_x11 = META_WINDOW_X11 (window); priv = meta_window_x11_get_instance_private (window_x11); @@ -4467,7 +4467,7 @@ meta_window_x11_get_user_time_window (MetaWindow *window) MetaWindowX11 *window_x11; MetaWindowX11Private *priv; - g_return_val_if_fail (META_IS_WINDOW (window), None); + g_return_val_if_fail (META_IS_WINDOW_X11 (window), None); window_x11 = META_WINDOW_X11 (window); priv = meta_window_x11_get_instance_private (window_x11); @@ -4480,7 +4480,7 @@ meta_window_x11_get_xtransient_for (MetaWindow *window) { MetaWindow *transient_for; - g_return_val_if_fail (META_IS_WINDOW (window), None); + g_return_val_if_fail (META_IS_WINDOW_X11 (window), None); transient_for = meta_window_get_transient_for (window); if (transient_for)