brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[clutter-interval] Fix calculation of interval for unsigned types

Browse Source 
The patch makes it cast to double before subtracting the original
value from the target value. Otherwise if the target value is less
than the original value then the subtraction will overflow and the
factor will be multiplied by a very large number instead of the
desired interval.

The problem is demonstrable using the border-width property of
ClutterRectangle.
This commit is contained in:
Neil Roberts 2008-12-17 19:26:24 +00:00
parent 140e4e1be2
commit 2bf815131a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
clutter/clutter-interval.c
View File

@ -206,7 +206,7 @@ clutter_interval_real_compute_value (ClutterInterval *interval,
ia = g_value_get_uint (initial);
ib = g_value_get_uint (final);
res = (factor * (ib - ia)) + ia;
res = (factor * (ib - (gdouble) ia)) + ia;
g_value_set_uint (value, res);
}
@ -219,7 +219,7 @@ clutter_interval_real_compute_value (ClutterInterval *interval,
ia = g_value_get_uchar (initial);
ib = g_value_get_uchar (final);
res = (factor * (ib - ia)) + ia;
res = (factor * (ib - (gdouble) ia)) + ia;
g_value_set_uchar (value, res);
}