Support keybindings again, too

This commit is contained in:
Jasper St. Pierre 2013-12-05 16:36:40 -05:00
parent fa65c380db
commit 283649b8d7
3 changed files with 25 additions and 19 deletions

View File

@ -1003,17 +1003,12 @@ meta_compositor_window_shape_changed (MetaCompositor *compositor,
* application toolkit. As such, it will ignore any events sent * application toolkit. As such, it will ignore any events sent
* to the a stage that isn't its X window. * to the a stage that isn't its X window.
* *
* When a user clicks on what she thinks is the wallpaper, she * When running as an X window manager, we need to respond to
* is actually clicking on the guard window, which is an entirely * events from lots of windows. Trick Clutter into translating
* separate top-level override-redirect window in the hierarchy. * these events by pretending we got an event on the stage window.
* We want to recieve events on this guard window so that users
* can right-click on the background actor. We do this by telling
* Clutter a little white lie, by transforming clicks on the guard
* window to become clicks on the stage window, allowing Clutter
* to process the event normally.
*/ */
static void static void
maybe_spoof_guard_window_event_as_stage_event (MetaCompScreen *info, maybe_spoof_event_as_stage_event (MetaCompScreen *info,
XEvent *event) XEvent *event)
{ {
MetaDisplay *display = meta_screen_get_display (info->screen); MetaDisplay *display = meta_screen_get_display (info->screen);
@ -1023,19 +1018,22 @@ maybe_spoof_guard_window_event_as_stage_event (MetaCompScreen *info,
{ {
XIEvent *input_event = (XIEvent *) event->xcookie.data; XIEvent *input_event = (XIEvent *) event->xcookie.data;
/* Only care about pointer events for now. */
switch (input_event->evtype) switch (input_event->evtype)
{ {
case XI_Motion: case XI_Motion:
case XI_ButtonPress: case XI_ButtonPress:
case XI_ButtonRelease: case XI_ButtonRelease:
case XI_KeyPress:
case XI_KeyRelease:
{ {
XIDeviceEvent *device_event = ((XIDeviceEvent *) input_event); XIDeviceEvent *device_event = ((XIDeviceEvent *) input_event);
if (device_event->event == info->screen->guard_window)
{ /* If this is a GTK+ widget, like a window menu, let GTK+ handle
Window xwin = clutter_x11_get_stage_window (CLUTTER_STAGE (info->stage)); * it as-is without mangling. */
device_event->event = xwin; if (meta_ui_window_is_widget (info->screen->ui, device_event->event))
} break;
device_event->event = clutter_x11_get_stage_window (CLUTTER_STAGE (info->stage));
} }
break; break;
default: default:
@ -1092,7 +1090,7 @@ meta_compositor_process_event (MetaCompositor *compositor,
info = meta_screen_get_compositor_data (screen); info = meta_screen_get_compositor_data (screen);
maybe_spoof_guard_window_event_as_stage_event (info, event); maybe_spoof_event_as_stage_event (info, event);
if (meta_plugin_manager_xevent_filter (info->plugin_mgr, event)) if (meta_plugin_manager_xevent_filter (info->plugin_mgr, event))
{ {

View File

@ -1707,9 +1707,19 @@ update_focus_window (MetaDisplay *display,
if (display->focus_window) if (display->focus_window)
{ {
ClutterActor *window_actor;
meta_topic (META_DEBUG_FOCUS, "* Focus --> %s with serial %lu\n", meta_topic (META_DEBUG_FOCUS, "* Focus --> %s with serial %lu\n",
display->focus_window->desc, serial); display->focus_window->desc, serial);
meta_window_set_focused_internal (display->focus_window, TRUE); meta_window_set_focused_internal (display->focus_window, TRUE);
/* XXX -- this is sort of a layer violation, but because we
* rely on the compositor for event delivery anyway, I don't
* think it's too bad... */
window_actor = CLUTTER_ACTOR (display->focus_window->compositor_private);
if (window_actor)
clutter_actor_grab_key_focus (window_actor);
} }
else else
meta_topic (META_DEBUG_FOCUS, "* Focus --> NULL with serial %lu\n", serial); meta_topic (META_DEBUG_FOCUS, "* Focus --> NULL with serial %lu\n", serial);

View File

@ -215,8 +215,6 @@ meta_wayland_compositor_set_input_focus (MetaWaylandCompositor *compositor,
meta_wayland_keyboard_set_focus (&compositor->seat->keyboard, meta_wayland_keyboard_set_focus (&compositor->seat->keyboard,
surface); surface);
meta_wayland_data_device_set_keyboard_focus (compositor->seat); meta_wayland_data_device_set_keyboard_focus (compositor->seat);
clutter_stage_set_key_focus (CLUTTER_STAGE (compositor->stage), window_actor);
} }
void void