brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

actor: Add a comment on the unmapping order

Browse Source 
Let's add a comment to avoid reshuffling the unmap() implementation and
end up triggering these bugs:

  http://bugzilla.clutter-project.org/show_bug.cgi?id=2621
  https://bugzilla.gnome.org/show_bug.cgi?id=652036
This commit is contained in:
Emmanuele Bassi 2011-08-23 10:58:09 +01:00
parent a661191b4b
commit 2559fb1d0d
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
clutter/clutter-actor.c
View File

@ -8329,7 +8329,17 @@ clutter_actor_unparent (ClutterActor *self)
/* We take this opportunity to invalidate any queue redraw entry /* We take this opportunity to invalidate any queue redraw entry
* associated with the actor and descendants since we won't be able to * associated with the actor and descendants since we won't be able to
* determine the appropriate stage after this. */ * determine the appropriate stage after this.
*
* we do this after we updated the mapped state because actors might
* end up queueing redraws inside their mapped/unmapped virtual
* functions, and if we invalidate the redraw entry we could end up
* with an inconsistent state and weird memory corruption. see
* bugs:
*
* http://bugzilla.clutter-project.org/show_bug.cgi?id=2621
* https://bugzilla.gnome.org/show_bug.cgi?id=652036
*/
_clutter_actor_traverse (self, _clutter_actor_traverse (self,
0, 0,
invalidate_queue_redraw_entry, invalidate_queue_redraw_entry,