brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

actor: Remove the implicit easing state save

Browse Source 
When setting the easing mode, duration, or delay without having ever
called clutter_actor_save_easing_state(). It's confusing, and not
really nice.

In the future, we'll have a default easing state implicitly created by
the actor itself, but for the time being explicitly opting in is
preferrable.
This commit is contained in:
Emmanuele Bassi 2012-03-17 16:46:38 +00:00
parent b3b1994c13
commit 229241b875
1 changed files with 18 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
clutter/clutter-actor.c
View File

@ -17241,10 +17241,6 @@ clutter_actor_remove_all_transitions (ClutterActor *self)
* Sets the duration of the tweening for animatable properties * Sets the duration of the tweening for animatable properties
* of @self for the current easing state. * of @self for the current easing state.
* *
* Calling this function will implicitly call
* clutter_actor_save_easing_state() if no previous call to
* that function was made.
*
* Since: 1.10 * Since: 1.10
*/ */
void void
@ -17257,8 +17253,12 @@ clutter_actor_set_easing_duration (ClutterActor *self,
info = _clutter_actor_get_animation_info (self); info = _clutter_actor_get_animation_info (self);
if (info->states == NULL) if (info->cur_state == NULL)
clutter_actor_save_easing_state (self); {
g_warning ("You must call clutter_actor_save_easing_state() prior "
"to calling clutter_actor_set_easing_duration().");
return;
}
if (info->cur_state->easing_duration != msecs) if (info->cur_state->easing_duration != msecs)
info->cur_state->easing_duration = msecs; info->cur_state->easing_duration = msecs;
@ -17298,10 +17298,6 @@ clutter_actor_get_easing_duration (ClutterActor *self)
* Sets the easing mode for the tweening of animatable properties * Sets the easing mode for the tweening of animatable properties
* of @self. * of @self.
* *
* Calling this function will implicitly call
* clutter_actor_save_easing_state() if no previous calls to
* that function were made.
*
* Since: 1.10 * Since: 1.10
*/ */
void void
@ -17316,8 +17312,12 @@ clutter_actor_set_easing_mode (ClutterActor *self,
info = _clutter_actor_get_animation_info (self); info = _clutter_actor_get_animation_info (self);
if (info->states == NULL) if (info->cur_state == NULL)
clutter_actor_save_easing_state (self); {
g_warning ("You must call clutter_actor_save_easing_state() prior "
"to calling clutter_actor_set_easing_mode().");
return;
}
if (info->cur_state->easing_mode != mode) if (info->cur_state->easing_mode != mode)
info->cur_state->easing_mode = mode; info->cur_state->easing_mode = mode;
@ -17357,10 +17357,6 @@ clutter_actor_get_easing_mode (ClutterActor *self)
* Sets the delay that should be applied before tweening animatable * Sets the delay that should be applied before tweening animatable
* properties. * properties.
* *
* Calling this function will implicitly call
* clutter_actor_save_easing_state() if no previous calls to
* that function were made.
*
* Since: 1.10 * Since: 1.10
*/ */
void void
@ -17373,8 +17369,12 @@ clutter_actor_set_easing_delay (ClutterActor *self,
info = _clutter_actor_get_animation_info (self); info = _clutter_actor_get_animation_info (self);
if (info->states == NULL) if (info->cur_state == NULL)
clutter_actor_save_easing_state (self); {
g_warning ("You must call clutter_actor_save_easing_state() prior "
"to calling clutter_actor_set_easing_delay().");
return;
}
if (info->cur_state->easing_delay != msecs) if (info->cur_state->easing_delay != msecs)
info->cur_state->easing_delay = msecs; info->cur_state->easing_delay = msecs;