brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

actor: don't immediately queue redraw when queuing relayout

Browse Source 
We have bent the originally documented semantics a bit so now where we
say "Queueing a new layout automatically queues a redraw as well" it
might be clearer to say "Queuing a new layout implicitly queues a redraw
as well if anything in the layout changes".

This should be close enough to the original semantics to not cause any
problems.

Without this change then we we fail to take advantage of clipped redraws
in a lot of cases because queuing a redraw with priv->needs_allocation
== TRUE will automatically be promoted to a full stage redraw since it's
not possible to determine a valid paint-volume.

Also queuing a redraw here will end up registering a redundant clipped
redraw for the current location, doing quite a lot of redundant
transforms, and then later when re-allocated during layouting another
queue redraw would happen with the correct paint-volume.
This commit is contained in:
Robert Bragg 2010-09-07 23:09:06 +01:00
parent b499696d83
commit 2235e70585
1 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
clutter/clutter-actor.c
View File

@ -5200,7 +5200,27 @@ clutter_actor_queue_relayout (ClutterActor *self)
{ {
_clutter_actor_queue_only_relayout (self); _clutter_actor_queue_only_relayout (self);
/* XXX: We have bent the originally documented semantics a bit so
* now where we say "Queueing a new layout automatically queues
* a redraw as well" it might be clearer to say "Queuing a new
* layout implicitly queues a redraw as well if anything in the
* layout changes".
*
* If we don't comment this out then we fail to take advantage
* of clipped redraws in a lot of cases because queuing a redraw
* with priv->needs_allocation == TRUE will automatically be
* promoted to a full stage redraw since it's not possible to
* determine a valid paint-volume.
*
* It doesn't just work to do the queue redraw first. I didn't debug
* why in detail but at the very least it would end up registering a
* redundant clipped redraw for the current location, doing quite a
* lot of redundant transforms, and then later when allocated
* another queue redraw will happen with the correct paint-volume.
*/
#if 0
clutter_actor_queue_redraw (self); clutter_actor_queue_redraw (self);
#endif
} }
/** /**