brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

window: Update the stack after setting the transient_for field

Browse Source 
Don't update the stack until after setting the window->transient_for
field. Updating before will cause the stack transient-for constraint to
be missing until the next time constraints are applied.

https://bugzilla.gnome.org/show_bug.cgi?id=755606
This commit is contained in:
Jonas Ådahl 2015-09-24 13:35:42 +08:00
parent 5054b2a99c
commit 213f0fa160
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/core/window.c
View File

@ -7417,14 +7417,14 @@ meta_window_set_transient_for (MetaWindow *window,
} }
} }
/* update stacking constraints */
if (!window->override_redirect)
meta_stack_update_transient (window->screen->stack, window);
/* We know this won't create a reference cycle because we check for loops */ /* We know this won't create a reference cycle because we check for loops */
g_clear_object (&window->transient_for); g_clear_object (&window->transient_for);
window->transient_for = parent ? g_object_ref (parent) : NULL; window->transient_for = parent ? g_object_ref (parent) : NULL;
/* update stacking constraints */
if (!window->override_redirect)
meta_stack_update_transient (window->screen->stack, window);
/* possibly change its group. We treat being a window's transient as /* possibly change its group. We treat being a window's transient as
* equivalent to making it your group leader, to work around shortcomings * equivalent to making it your group leader, to work around shortcomings
* in programs such as xmms-- see #328211. * in programs such as xmms-- see #328211.