brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

monitor-unit-tests: initial crtcs in custom_lid_switch

Browse Source 
This test forgot to specify the existing CRTC routings in the setup. For the
first output the default 0 was ok, now it is -1 to ensure that the code will
assign it correctly. For the second output the default 0 was incorrect, because
possible_crtcs does not include 0.  Now that CRTC is initialized to off
instead, because the second output is hotplugged later and running a CRTC
without an output does not make sense.

This fix will keep this test passing when a future patch attempts to preserve
existing CRTC routings. Assuming that any existing routing is valid, such
routing will be kept. In this test case the existing routing was illegal, it
should have been impossible, which then causes that future patch to fail the
test by assigning the wrong CRTC.

https://gitlab.gnome.org/GNOME/mutter/issues/373
This commit is contained in:
Pekka Paalanen 2019-01-29 14:27:25 +02:00
parent 79f90c147c
commit 1c67260bd4
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/tests/monitor-unit-tests.c
View File

@ -5291,6 +5291,7 @@ meta_test_monitor_custom_lid_switch_config (void)
.n_modes = 1, .n_modes = 1,
.outputs = { .outputs = {
{ {
.crtc = -1,
.modes = { 0 }, .modes = { 0 },
.n_modes = 1, .n_modes = 1,
.preferred_mode = 0, .preferred_mode = 0,
@ -5301,6 +5302,7 @@ meta_test_monitor_custom_lid_switch_config (void)
.is_laptop_panel = TRUE .is_laptop_panel = TRUE
}, },
{ {
.crtc = -1,
.modes = { 0 }, .modes = { 0 },
.n_modes = 1, .n_modes = 1,
.preferred_mode = 0, .preferred_mode = 0,