brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mutter-launch: Don't test the argument name to validate launching things

Browse Source 
Somebody could do:

  $ mv my-evil-program mutter-wayland
  $ PATH=.:$PATH mutter-launch mutter-wayland

It's not secure, and it's hard to test with, so just drop it for now
We'll be relying on logind to hand us permissions in the future.
This commit is contained in:
Jasper St. Pierre 2013-11-20 13:12:38 -05:00
parent f4fc498e65
commit 1c0e6f26e2
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/wayland/weston-launch.c
View File

@ -738,9 +738,6 @@ main(int argc, char *argv[])
if (optind >= argc) if (optind >= argc)
error(1, 0, "Expected program argument"); error(1, 0, "Expected program argument");
if (strcmp (argv[optind], "mutter-wayland") &&
strcmp (argv[optind], "gnome-shell-wayland"))
error(1, 0, "mutter-launch can only be used to launch mutter or gnome-shell");
wl.pw = getpwuid(getuid()); wl.pw = getpwuid(getuid());
if (wl.pw == NULL) if (wl.pw == NULL)