brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

core: Hide close dialog before destroying

Browse Source 
The MetaCloseDialog implementation object may stay artifically alive
for a longer period. This was usually fine till gnome-shell commit
b03bcc85aad, as the check_alive() timeout will keep running even
though the window went unmanaged/destroyed, leading to crashes.

In order to fix this, forcibly hide the dialog if it is visible and
the window is being unmanaged, so the timeout is stopped in time.


(cherry picked from commit 6abe4703c7)
This commit is contained in:
Carlos Garnacho 2018-06-06 11:26:55 +00:00 committed by Marco Trevisan
parent 4ca83f3c47
commit 17ae09ad3f
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/core/delete.c
View File

@ -115,5 +115,8 @@ meta_window_kill (MetaWindow *window)
void void
meta_window_free_delete_dialog (MetaWindow *window) meta_window_free_delete_dialog (MetaWindow *window)
{ {
if (window->close_dialog &&
meta_close_dialog_is_visible (window->close_dialog))
meta_close_dialog_hide (window->close_dialog);
g_clear_object (&window->close_dialog); g_clear_object (&window->close_dialog);
} }