From 088e0c1ee7edaa2e711c17a5db330157878cd538 Mon Sep 17 00:00:00 2001
From: "Jasper St. Pierre" <jstpierre@mecheye.net>
Date: Mon, 12 Sep 2011 22:52:26 -0400
Subject: [PATCH] MetaWindowActor: Make sure to always pop an error trap

https://bugzilla.gnome.org/show_bug.cgi?id=658228
---
 src/compositor/meta-window-actor.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/compositor/meta-window-actor.c b/src/compositor/meta-window-actor.c
index 7660e40dd..f85eb5150 100644
--- a/src/compositor/meta-window-actor.c
+++ b/src/compositor/meta-window-actor.c
@@ -1884,7 +1884,7 @@ check_needs_pixmap (MetaWindowActor *self)
         {
           meta_verbose ("Unable to get named pixmap for %p\n", self);
           meta_window_actor_update_bounding_region_and_borders (self, 0, 0);
-          return;
+          goto out;
         }
 
       if (compositor->no_mipmaps)
@@ -1910,9 +1910,10 @@ check_needs_pixmap (MetaWindowActor *self)
       meta_window_actor_update_bounding_region_and_borders (self, pxm_width, pxm_height);
     }
 
-  meta_error_trap_pop (display);
-
   priv->needs_pixmap = FALSE;
+
+ out:
+  meta_error_trap_pop (display);
 }
 
 static void