brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
873449d0f9
mutter/src/tests/stacking/set-override-redirect-parent.metatest

38 lines
388 B
Plaintext
Raw Normal View History

window-props: Don't set override redirect windows as top-level parent Java applications might use override-redirect windows as parent windows for top-level windows, although this is not following the standard [1]. In such case, the first non-override-redirect child window that is created was marked as being on_all_workspaces since the call to should_be_on_all_workspaces() returns TRUE for its parent, and this even though the on_all_workspaces_requested bit is unset. When a further child of this window was added, it was set as not having a workspace and not being on_all_workspaces, since the call to should_be_on_all_workspaces() for its parent would return FALSE (unless if it is in a different monitor, and the multiple-monitors workspaces are disabled). Since per commit 09bab98b we don't recompute the workspace if the on_all_workspaces bit is unset, we could end up in a case where a window can be nor in all the workspaces or in a specific workspace. So let's just ignore the transient_for bit for a window if that points to an override-redirect, using the x11 root window instead. Add a stacking test to verify this scenario (was failing before of this commit). Fixes https://gitlab.gnome.org/GNOME/mutter/issues/885 https://gitlab.gnome.org/GNOME/mutter/merge_requests/895 [1] https://standards.freedesktop.org/wm-spec/wm-spec-latest.html#idm140200472512128
2019-10-28 23:22:19 -04:00
new_client 1 x11
create 1/1 override
show 1/1
create 1/2
set_parent 1/2 1
show 1/2
create 1/3
set_parent 1/3 2
show 1/3
new_client 2 x11
create 2/1
show 2/1
create 2/2 override
set_parent 2/2 1
show 2/2
create 2/3
set_parent 2/3 2
show 2/3
window-props: Read WM_TRANSIENT_FOR for override-redirect windows As per the Extended Window Manager Hints standard version 1.3 [1] an override-redirect window can set a transient-for window per compositing and app-matching purposes. So just read the WM_TRASIENT_FOR property also for such windows, adapting the error in case they are transient for another O-R window and adding a test to check such case. [1] https://standards.freedesktop.org/wm-spec/wm-spec-latest.html#idm140200472512128 https://gitlab.gnome.org/GNOME/mutter/merge_requests/920
2019-10-29 14:08:01 -04:00
new_client 3 x11
create 3/1 override
show 3/1
create 3/2 override
set_parent 3/2 1
show 3/2
create 3/3 override
set_parent 3/3 2
show 3/3
Reference in New Issue Copy Permalink