2019-02-05 12:19:43 -05:00
|
|
|
#!/usr/bin/env bash
|
|
|
|
|
|
|
|
if [ -z "$CI_MERGE_REQUEST_TARGET_BRANCH_NAME" ]; then
|
|
|
|
echo Cannot review non-merge request
|
|
|
|
exit 1
|
|
|
|
fi
|
|
|
|
|
|
|
|
git fetch $CI_MERGE_REQUEST_PROJECT_URL.git $CI_MERGE_REQUEST_TARGET_BRANCH_NAME
|
|
|
|
|
|
|
|
branch_point=$(git merge-base HEAD FETCH_HEAD)
|
|
|
|
|
|
|
|
commits=$(git log --format='format:%H' $branch_point..$CI_COMMIT_SHA)
|
|
|
|
|
|
|
|
if [ -z "$commits" ]; then
|
|
|
|
echo Commit range empty
|
|
|
|
exit 1
|
|
|
|
fi
|
|
|
|
|
2020-11-04 12:44:01 -05:00
|
|
|
function commit_message_has_mr_url() {
|
2019-02-05 12:19:43 -05:00
|
|
|
commit=$1
|
|
|
|
commit_message=$(git show -s --format='format:%b' $commit)
|
2020-11-04 12:44:01 -05:00
|
|
|
echo "$commit_message" | grep -qe "^$CI_MERGE_REQUEST_PROJECT_URL\/\(-\/\)\?merge_requests\/$CI_MERGE_REQUEST_IID$"
|
2019-02-05 12:19:43 -05:00
|
|
|
return $?
|
|
|
|
}
|
|
|
|
|
2019-04-01 07:10:10 -04:00
|
|
|
function commit_message_subject_is_compliant() {
|
|
|
|
commit=$1
|
|
|
|
commit_message_subject=$(git show -s --format='format:%s' $commit)
|
|
|
|
|
|
|
|
if echo "$commit_message_subject" | grep -qe "\(^meta-\|^Meta\)"; then
|
|
|
|
echo " - message subject should not be prefixed with 'meta-' or 'Meta'"
|
|
|
|
return 1
|
|
|
|
fi
|
|
|
|
|
2020-11-04 11:19:56 -05:00
|
|
|
if echo "$commit_message_subject" | grep -qe "\(^clutter-\|^Clutter\)"; then
|
|
|
|
echo " - message subject should not be prefixed with 'clutter-' or 'Clutter', use 'clutter/' instead"
|
|
|
|
return 1
|
|
|
|
fi
|
|
|
|
|
|
|
|
if echo "$commit_message_subject" | grep -qe "\(^cogl-\|^Cogl\)"; then
|
|
|
|
echo " - message subject should not be prefixed with 'cogl-' or 'Cogl', use 'cogl/' instead"
|
|
|
|
return 1
|
|
|
|
fi
|
|
|
|
|
2020-11-04 11:51:04 -05:00
|
|
|
if echo "$commit_message_subject" | sed -e 's/^[^:]\+: //' | grep -qe '^[[:lower:]]'; then
|
|
|
|
echo " - message subject should be properly Capitalized. E.g. 'window: Marginalize extradicity'"
|
|
|
|
return 1
|
|
|
|
fi
|
|
|
|
|
2019-04-02 04:47:06 -04:00
|
|
|
if echo "$commit_message_subject" | grep -qe "\.[ch]:"; then
|
|
|
|
echo " - message subject prefix should not include .c, .h, etc."
|
|
|
|
return 1
|
|
|
|
fi
|
|
|
|
|
2019-04-01 07:10:10 -04:00
|
|
|
return 0
|
|
|
|
}
|
|
|
|
|
2019-10-21 07:19:16 -04:00
|
|
|
RET=0
|
2019-02-05 12:19:43 -05:00
|
|
|
for commit in $commits; do
|
2019-04-01 07:10:10 -04:00
|
|
|
commit_short=$(echo $commit | cut -c -8)
|
|
|
|
|
2020-11-04 12:44:01 -05:00
|
|
|
if commit_message_has_mr_url $commit; then
|
|
|
|
echo "Commit $commit_short must not contain a link to its own merge request"
|
2019-04-01 07:10:10 -04:00
|
|
|
exit 1
|
|
|
|
fi
|
|
|
|
|
|
|
|
errors=$(commit_message_subject_is_compliant $commit)
|
|
|
|
if [ $? != 0 ]; then
|
|
|
|
echo "Commit message for $commit_short is not compliant:"
|
|
|
|
echo "$errors"
|
2019-10-21 07:19:16 -04:00
|
|
|
RET=1
|
2019-02-05 12:19:43 -05:00
|
|
|
fi
|
|
|
|
done
|
2019-10-21 07:19:16 -04:00
|
|
|
|
|
|
|
exit $RET
|