dc931e82cd
strstr() in find_class_name() will always consider "" a match so the loop was not stopping at the end of the class_list. None of the matches within the class_list would satisfy the return conditions, unless the class_list was either an empty string as well or has a trailing space. So this ends up with a match outside of the allocated string that happens to satisfy these conditions by chance which then leads to the class string containing some of this unrelated memory. Or it might lead to a segfault. This adds checks to the public API that uses find_class_name() to prevent extensions from accidentally triggering a crash this way or having some otherwise unexpected results. Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7152 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3006>
GNOME Shell
GNOME Shell provides core user interface functions for the GNOME desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience.
For more information about GNOME Shell, including instructions on how to build GNOME Shell from source and how to get involved with the project, see the project wiki.
Bugs should be reported to the GNOME bug tracking system. Please refer to the Schedule wiki page to see the supported versions.
Contributing
To contribute, open merge requests at https://gitlab.gnome.org/GNOME/gnome-shell.
Commit messages should follow the GNOME commit message
guidelines. If a merge request
fixes an existing issue, it is good practice to append the full issue URL
to each commit message. Try to always prefix commit subjects with a relevant
topic, such as panel: or status/network:, and it's always better to write
too much in the commit message body than too little.
Default branch
The default development branch is main. If you still have a local
checkout under the old name, use:
git checkout master
git branch -m master main
git fetch
git branch --unset-upstream
git branch -u origin/main
git symbolic-ref refs/remotes/origin/HEAD refs/remotes/origin/main
License
GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.