b781b3e9fd
_getLinearPosition() is a function that converts a page and position index to the "accumulated" index that includes all pages before the page. The function is used by _addItem() and _moveItem() for getting the new index of an item inside the _orderedItems array. Now when passing -1 as position to _addItem() or _moveItem(), this means the item should be appended to the page. Right now _getLinearPosition() returns the last item index on the page when passed -1, inserting the item into _orderedItems at this index will actually not append it, but insert it between the second last and last item. To fix it, let's make the whole thing more robust by explicitly passing an item to _getLinearPosition(). This means we simply no longer have to assume what "-1" means. Moving the call to _getLinearPosition() to happen after addItem() and moveItem() ensures that the new item position is used and not the old one. This fixes issues where the _orderedItems array gets out of order when moving or adding items. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2348>
GNOME Shell
GNOME Shell provides core user interface functions for the GNOME desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience.
For more information about GNOME Shell, including instructions on how to build GNOME Shell from source and how to get involved with the project, see the project wiki.
Bugs should be reported to the GNOME bug tracking system. Please refer to the Schedule wiki page to see the supported versions.
Contributing
To contribute, open merge requests at https://gitlab.gnome.org/GNOME/gnome-shell.
Commit messages should follow the GNOME commit message
guidelines. If a merge request
fixes an existing issue, it is good practice to append the full issue URL
to each commit message. Try to always prefix commit subjects with a relevant
topic, such as panel: or status/network:, and it's always better to write
too much in the commit message body than too little.
Default branch
The default development branch is main. If you still have a local
checkout under the old name, use:
git checkout master
git branch -m master main
git fetch
git branch --unset-upstream
git branch -u origin/main
git symbolic-ref refs/remotes/origin/HEAD refs/remotes/origin/main
License
GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.