brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
b058e89166
gnome-shell/src
History
Georges Basile Stavracas Neto 2717ca9d08
st-box-layout: Pass correct allocation box to layout manager 
StBoxLayout implements StScrollable, which, semantically, means that
the StBoxLayout size may not match the minimum size reported by the
layout manager. In this specific case, the layout manager by is a
ClutterBoxLayout by default. For example:

        +--------------+
        |   Viewport   |
 +------+--------------+-----------------+
 |      |              |                 |
 |      |              |     Content     |
 |      |              |                 |
 +------+--------------+-----------------+
        |              |
        +--------------+

So, assuming that:

 - ContentSize = the minimum size of the content;
 - ViewportSize = the allocated size of the viewport;

When allocating StBoxLayout, it must assume ViewportSize, but must
pass ContentSize to the layout manager. That way, the children of
StBoxLayout are correctly placed within it, even if it's bigger than
ViewportSize.

And here's the problem: right now, StBoxLayout assumes ViewportSize
AND also passes it to layout manager. Commit 77c4c6b6d specifically
exposed this bug by relying entirely on StBoxLayout to arrange the
app and window icons.

Fix that by using ViewportSize to allocate StBoxLayout itself, but
passing ContentSize to the layout manager.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/153
2018-10-08 22:42:24 -03:00
..
calendar-server calendar-server: Update views only after the time range is set 2018-05-02 16:10:33 +02:00
hotplug-sniffer build: Support the meson build system 2017-07-20 00:20:54 +02:00
st st-box-layout: Pass correct allocation box to layout manager 2018-10-08 22:42:24 -03:00
tray build: Support the meson build system 2017-07-20 00:20:54 +02:00
data-to-c.pl build: Fix the path of perl for data-to-c.pl 2015-05-22 19:03:44 +08:00
gnome-shell-extension-prefs.c build: Don't modify typelib search path in tools 2018-08-14 17:28:03 +00:00
gnome-shell-extension-tool.in build: Support the meson build system 2017-07-20 00:20:54 +02:00
gnome-shell-perf-tool.in perf-tool: Fix default value for --extra-filter 2018-04-29 16:15:16 +00:00
gnome-shell-plugin.c Remove usage of MetaScreen 2018-07-06 19:56:19 +02:00
gnome-shell-portal-helper.c build: Don't modify typelib search path in tools 2018-08-14 17:28:03 +00:00
gtkactionmuxer.c build: Fix build with clang -Werror 2016-02-26 02:06:55 +08:00
gtkactionmuxer.h
gtkactionobservable.c
gtkactionobservable.h
gtkactionobserver.c
gtkactionobserver.h
gtkmenutracker.c menutracker: Don't shadow existing variables 2015-09-23 21:32:49 +02:00
gtkmenutracker.h
gtkmenutrackeritem.c menutracker: Fix a small memory leak 2018-03-02 19:43:45 +00:00
gtkmenutrackeritem.h
main.c Replace custom override schema with per-desktop override 2018-07-31 18:36:26 +00:00
meson.build shell: Fix list of GIR includes 2018-09-25 23:57:51 +00:00
org.gtk.Application.xml Generate GDBus proxy object for org.gtk.Application 2014-11-27 10:59:55 +00:00
run-js-test.c Don't set clutters 'window-scaling-factor' property 2017-04-07 22:30:35 +08:00
shell-action-modes.h Drop MESSAGE_TRAY action mode 2015-02-26 01:41:18 +01:00
shell-app-private.h
shell-app-system-private.h
shell-app-system.c Properly detect changes in .desktop files 2017-01-23 17:25:39 -06:00
shell-app-system.h shell: Use G_DECLARE_*_TYPE macros 2015-10-15 22:58:28 +02:00
shell-app-usage.c shell: Don't avoid parameter list 2015-09-23 21:32:50 +02:00
shell-app-usage.h shell: Use G_DECLARE_*_TYPE macros 2015-10-15 22:58:28 +02:00
shell-app.c app: Close all closable windows from quit() 2018-09-13 10:54:39 +00:00
shell-app.h shell-app: Add "discrete_gpu" option when launching apps 2016-10-21 19:26:49 +02:00
shell-embedded-window-private.h
shell-embedded-window.c shell: Use G_DECLARE_*_TYPE macros 2015-10-15 22:58:28 +02:00
shell-embedded-window.h shell: Use G_DECLARE_*_TYPE macros 2015-10-15 22:58:28 +02:00
shell-generic-container.c shell: Use G_DECLARE_*_TYPE macros 2015-10-15 22:58:28 +02:00
shell-generic-container.h shell: Use G_DECLARE_*_TYPE macros 2015-10-15 22:58:28 +02:00
shell-global-private.h main: Destroy GjsContext before exit 2016-12-07 11:34:15 -08:00
shell-global.c Replace custom override schema with per-desktop override 2018-07-31 18:36:26 +00:00
shell-global.h Replace custom override schema with per-desktop override 2018-07-31 18:36:26 +00:00
shell-glsl-quad.c build: Fix build with clang -Werror 2016-02-26 02:06:55 +08:00
shell-glsl-quad.h shell: Use G_DECLARE_*_TYPE macros 2015-10-15 22:58:28 +02:00
shell-gtk-embed.c gtk-embed: ensure we only listen for window-created events once 2017-09-15 15:32:46 -04:00
shell-gtk-embed.h shell: Use G_DECLARE_*_TYPE macros 2015-10-15 22:58:28 +02:00
shell-invert-lightness-effect.c shell-invert-lightness-effect: Fix Cogl deprecations 2015-02-20 17:40:46 -08:00
shell-invert-lightness-effect.h shell: Define COGL_ENABLE_EXPERIMENTAL_API and related defines globally 2014-08-07 14:49:54 -04:00
shell-keyring-prompt.c shell: Port to GTask 2015-10-15 22:59:49 +02:00
shell-keyring-prompt.h shell: Use G_DECLARE_*_TYPE macros 2015-10-15 22:58:28 +02:00
shell-menu-tracker.c
shell-menu-tracker.h
shell-mount-operation.c shell: Use G_DECLARE_*_TYPE macros 2015-10-15 22:58:28 +02:00
shell-mount-operation.h shell: Use G_DECLARE_*_TYPE macros 2015-10-15 22:58:28 +02:00
shell-network-agent.c network: port to libnm 2018-01-12 11:48:49 +01:00
shell-network-agent.h network: port to libnm 2018-01-12 11:48:49 +01:00
shell-perf-helper.c shell: Don't mix declarations and code 2015-09-23 21:32:50 +02:00
shell-perf-log.c shell: Use G_DECLARE_*_TYPE macros 2015-10-15 22:58:28 +02:00
shell-perf-log.h shell: Use G_DECLARE_*_TYPE macros 2015-10-15 22:58:28 +02:00
shell-polkit-authentication-agent.c shell: Fix crash in polkit agent 2015-11-10 11:56:37 +01:00
shell-polkit-authentication-agent.h
shell-recorder-src.c recorder-src: Rewrite switch statement 2015-09-23 21:32:49 +02:00
shell-recorder-src.h
shell-recorder.c Remove usage of MetaScreen 2018-07-06 19:56:19 +02:00
shell-recorder.h shell: Use G_DECLARE_*_TYPE macros 2015-10-15 22:58:28 +02:00
shell-screenshot.c screenshot: Add pick_color() method 2018-07-30 16:55:10 +00:00
shell-screenshot.h screenshot: Add pick_color() method 2018-07-30 16:55:10 +00:00
shell-secure-text-buffer.c shell: Use G_DECLARE_*_TYPE macros 2015-10-15 22:58:28 +02:00
shell-secure-text-buffer.h shell: Use G_DECLARE_*_TYPE macros 2015-10-15 22:58:28 +02:00
shell-stack.c shell: Use G_DECLARE_*_TYPE macros 2015-10-15 22:58:28 +02:00
shell-stack.h shell: Use G_DECLARE_*_TYPE macros 2015-10-15 22:58:28 +02:00
shell-tray-icon.c systray: Bail out if the plug window is gone 2016-09-08 12:08:02 +02:00
shell-tray-icon.h shell: Use G_DECLARE_*_TYPE macros 2015-10-15 22:58:28 +02:00
shell-tray-manager.c Remove usage of MetaScreen 2018-07-06 19:56:19 +02:00
shell-tray-manager.h Remove usage of MetaScreen 2018-07-06 19:56:19 +02:00
shell-util.c util: Fix code style 2018-07-30 21:23:28 -03:00
shell-util.h build: Remove obsolete soup dependency 2018-09-25 23:57:51 +00:00
shell-window-tracker-private.h
shell-window-tracker.c Remove usage of MetaScreen 2018-07-06 19:56:19 +02:00
shell-window-tracker.h shell: Use G_DECLARE_*_TYPE macros 2015-10-15 22:58:28 +02:00
shell-wm-private.h ui: Add InhibitShortcutsDialog 2017-08-02 11:27:42 +01:00
shell-wm.c ui: Add InhibitShortcutsDialog 2017-08-02 11:27:42 +01:00
shell-wm.h shell: Use G_DECLARE_*_TYPE macros 2015-10-15 22:58:28 +02:00