a09feb4b47
As outlined in commit 36b8dcbe07, we can end up with wrong icons if the icon theme changes right after a GTK theme change to/from HighContrast triggered a theme reload. That's because when we reload icons for the new icon theme, there are already pending requests due to the icon-style change; those requests are simply re-used for the new icons, with the existing icon infos from the old theme. The above commit applied a simple work-around by changing the icon theme before the GTK theme, but that only works for the HighContrast switch in our own UI. It turns out that Settings also uses the "wrong" order, so the issue still reproduces with the Universal Access panel. So instead of relying on everything changing the settings in the order we expect, cancel all ongoing requests on icon-theme changes. https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1277 (cherry picked from commit d81237b9d60e1cf95266533458598055dd93e4aa)
GNOME Shell
GNOME Shell provides core user interface functions for the GNOME 3 desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience.
For more information about GNOME Shell, including instructions on how to build GNOME Shell from source and how to get involved with the project, see the project wiki.
Bugs should be reported to the GNOME bug tracking system.
Contributing
To contribute, open merge requests at https://gitlab.gnome.org/GNOME/gnome-shell.
Commit messages should follow the GNOME commit message guidelines. We require an URL to either an issue or a merge request in each commit.
License
GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.