Go to file
Jonas Dreßler 95f4a1ecd6 windowPreview: Avoid LEAVE events triggered by grab of our own StButton
Since the ClutterGrab rework, grabbing properly emits crossing events.

StButtons take a ClutterGrab as soon as they are pressed, so pressing
the close StButton of the WindowPreview takes a grab and causes a
LEAVE+key-focus-out event getting sent to the WindowPreview. This in
turn makes us hide our overlay (which the StButton is part of). We
automatically ungrab ClutterGrabs when hiding actors, so the StButtons
grab now gets released again, key-focus and hover state are updated
again and we emit an ENTER event to the WindowPreview. The preview now
tries show its overlay again and things explode because we re-enter the
mapping machinery.

For the LEAVE event we can break this cycle by detecting the GRAB_NOTIFY
crossing event of our own StButton and not reacting to that.

We should do the same for the key-focus-out event, but these don't pass
context information like a GRAB_NOTIFY flag yet, so just check the
current grab actor here.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3165

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2231>
2022-03-20 21:42:16 +00:00
.gitlab/issue_templates Add a link to supported releases in the README and bug template 2021-03-03 14:47:20 +00:00
.gitlab-ci ci: Cover more node types in check-potfiles 2022-03-05 00:12:27 +00:00
.settings Clean out some eclipse artefacts 2019-02-13 04:39:26 +01:00
data theme: Minor screenshot UI fixes 2022-03-20 20:51:19 +00:00
docs/reference build: Replace deprecated meson functions 2021-12-23 15:52:21 +00:00
js windowPreview: Avoid LEAVE events triggered by grab of our own StButton 2022-03-20 21:42:16 +00:00
lint cleanup: Use new indentation style for object literals 2022-02-23 12:23:52 +00:00
man man: Update options 2020-12-28 02:25:17 +01:00
meson build: Use meson's gnome.post_install() 2021-12-23 15:52:21 +00:00
po Update Italian translation 2022-03-17 08:38:05 +00:00
src st: Generate shadows from the silhouette of the source texture 2022-03-05 13:55:37 +00:00
subprojects Bump version to 42.0 2022-03-12 22:43:13 +01:00
tests signalTracker: Explicitly register destroyable types 2022-03-06 00:10:03 +00:00
tools *: Fix spelling mistakes found by codespell 2020-08-21 18:25:09 +00:00
.eslintrc.yml init: Set console log domain 2021-09-01 14:55:47 +00:00
.gitignore Add small gnome-shell-extension-prefs script 2020-04-28 00:06:19 +02:00
.gitlab-ci.yml ci: Bump mutter CI image 2022-03-04 22:05:45 +00:00
.gitmodules submodules: Replace non-functional git.gnome.org URL by GNOME Gitlab URL 2018-09-25 08:41:30 +02:00
.jscheckignore init: Set console log domain 2021-09-01 14:55:47 +00:00
config.h.meson main: Use mallinfo2 when available at build time 2021-07-07 14:44:30 +00:00
COPYING Changed obsolete FSF postal address. 2014-01-08 04:35:14 +07:00
gnome-shell.doap gnome-shell.doap: Make marge-bot a maintainer 2020-11-17 17:29:56 +00:00
HACKING.md *: Fix spelling mistakes found by codespell 2020-08-21 18:25:09 +00:00
meson_options.txt build: Add option to turn off tests 2021-09-07 12:53:47 +00:00
meson.build Bump version to 42.0 2022-03-12 22:43:13 +01:00
NEWS Bump version to 42.0 2022-03-12 22:43:13 +01:00
README.md readme: Change "GNOME 3" to "GNOME" 2021-08-11 14:41:15 +00:00

GNOME Shell

GNOME Shell provides core user interface functions for the GNOME desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience.

For more information about GNOME Shell, including instructions on how to build GNOME Shell from source and how to get involved with the project, see the project wiki.

Bugs should be reported to the GNOME bug tracking system. Please refer to the Schedule wiki page to see the supported versions.

Contributing

To contribute, open merge requests at https://gitlab.gnome.org/GNOME/gnome-shell.

Commit messages should follow the GNOME commit message guidelines. We require an URL to either an issue or a merge request in each commit.

Default branch

The default development branch is main. If you still have a local checkout under the old name, use:

git checkout master
git branch -m master main
git fetch
git branch --unset-upstream
git branch -u origin/main
git symbolic-ref refs/remotes/origin/HEAD refs/remotes/origin/main

License

GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.