93b33cf314
In commit e69da36095d5093c1c7bec7a9c96c079c0b837f9, Florian Müllner wrote: > We currently complete the animation using an onComplete handler, > which only runs if the corresponding transition was stopped when > finished. > > While it is unexpected that the transition is interrupted, it can > apparently happen under some circumstances (like VMs with qlx). > The consequences of that are pretty bad, mainly due to the cover > pane that prevents input during the animation not getting removed. > > Address this by always completing the animation when the transition > is stopped, regardless of whether it completed or not. There are effectively four branches of the startup animation: 1. if Meta.is_restart() is true, no animation is run on startup; I believe this is the X11-only case of restarting the shell mid-session. 2. if Main.sessionMode.isGreeter is true, just the panel is eased onto the screen; this is the GDM case. 3. if Main.sessionMode.hasOverview is true, then a whole sequence of animations are run; this is the normal session case. 4. otherwise, the whole UI zooms in to full size, and from full transparency to full opacity; this is the Initial Setup case. The fix above handles cases 2 and 4, but not 3. This patch applies the same fix to case 3, so that the callback is always called on session startup even if the transition is interrupted. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3422>
GNOME Shell
GNOME Shell provides core user interface functions for the GNOME desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience.
All interactions with the project should follow the Code of Conduct.
Supported versions
Upstream gnome-shell only supports the most recent stable release series, the previous stable release series, and the current development release series. Any older stable release series are no longer supported, although they may still receive backported security updates in long-term support distributions. Such support is up to the distributions, though.
Please refer to the schedule to see when a new version will be released.
Reporting bugs
Bugs should be reported to the issue tracking system.
The GNOME handbook has useful information for creating effective issue reports.
If you are using extensions, please confirm that an issue still happens without extensions. To properly disable extensions you can use the extensions-app and then restart your session. Disabling extensions without a restart is not sufficient to rule out extensions as the cause of a bug. If an issue can only be reproduced with a certain extension, please file an issue report against that extension first.
Please note that the issue tracker is meant to be used for actionable issues only.
For support questions, feedback on changes or general discussions, you can use:
- the #gnome-shell matrix room
- the
Desktopcategory orshelltag on GNOME Discourse
Feature requests
gnome-shell is a core compoment of the GNOME desktop experience. As such, any changes in behavior or appearance only happen in accordance with the GNOME design team.
For major changes, it is best to start a discussion on discourse and reach out on the #gnome-design matrix room, and only involve the issue tracker once agreement has been reached.
In particular mockups must be approved by the design team to be considered for implementation.
For enhancements that are limited in scope and well-defined, it is acceptable to directly open a feature request.
When in doubt, it is better to ask before opening an issue.
Contributing
To contribute, open merge requests at https://gitlab.gnome.org/GNOME/gnome-shell.
It can be useful to first look at the GNOME handbook.
If a change likely requires discussion beyond code review, it is probably better to open an issue first, or follow the process for feature requests. Otherwise, creating a separate issue is not required.
The following guidelines will help your change to be successfully merged:
- Keep the change as small as possible. If you can split it into multiple merge requests, please do so.
- Use multiple commits. This makes it easier to review and helps to diagnose bugs in the future.
- Use clear commit messages following the conventions.
- Pay attention to the CI results. Merge requests cannot be merged until the CI passes.
There's also a small guide for newcomers with a few more basic tips and tricks.
Documentation
- Coding style and conventions for javascript
- Coding style and conventions for C code
- The GJS Developer Guide
- Building and Running
- Debugging
API Reference
- Meta: Display server and window manager
- St: Shell toolkit
- Clutter: OpenGL based scene graph
- Shell: Non-ui shell objects and utilities
- See the mutter page for additional documentation
License
GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.