Joaquim Rocha 89bf360bad polkitAgent: Use dialog as confirmation when the user has no password ... When a user has no password and a polkit authentication is started, instead of blindly initiating the admin session, show the regular "Authentication Requested" dialog (but without the password entry). This makes sure that the user's admin session is only effectively started after the user chooses to proceed with the authentication, which provides an extra confirmation step that can be vital for critical tasks. To do this, we show the dialog inside `_onUserChanged()` right after the dialog was created instead of calling `performAuthentication()` from `_onInitiate()`. The bug mentioned in `_onInitiate()` is no longer an issue since we show the dialog in all cases now anyway. Ideally we should use a different wording than "authentication" when the user has no password set, and use "confirmation" instead. However polkit already sends the requests with such messages (e.g. "Authentication is required to configure software repositories"), and it's important to show those to the user, so this patch keeps the regular wording. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/829		2019-11-16 12:09:25 +01:00
..
components	polkitAgent: Use dialog as confirmation when the user has no password	2019-11-16 12:09:25 +01:00
status	style: Allow lonely ifs where appropriate	2019-11-11 23:51:17 +00:00
accessDialog.js	cleanup: Require "dangling" commas	2019-11-11 19:25:14 +00:00
altTab.js	cleanup: Use JSDoc for documentation comments	2019-11-11 19:25:14 +00:00
animation.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
appDisplay.js	folderView: Center folder icon	2019-11-11 18:12:32 -03:00
appFavorites.js	Update shotwell desktop file name references	2019-10-18 16:50:57 +02:00
audioDeviceSelection.js	cleanup: Require "dangling" commas	2019-11-11 19:25:14 +00:00
background.js	background: Add exception to no-loop-func rule	2019-11-11 23:51:17 +00:00
backgroundMenu.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
barLevel.js	cleanup: Require "dangling" commas	2019-11-11 19:25:14 +00:00
boxpointer.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
calendar.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
checkBox.js	st: Remove StBin's align properties	2019-11-04 21:27:56 +01:00
closeDialog.js	cleanup: Require "dangling" commas	2019-11-11 19:25:14 +00:00
ctrlAltTab.js	cleanup: Require "dangling" commas	2019-11-11 19:25:14 +00:00
dash.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
dateMenu.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
dialog.js	cleanup: Require "dangling" commas	2019-11-11 19:25:14 +00:00
dnd.js	cleanup: Use JSDoc for documentation comments	2019-11-11 19:25:14 +00:00
edgeDragAction.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
endSessionDialog.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
environment.js	cleanup: Require "dangling" commas	2019-11-11 19:25:14 +00:00
extensionDownloader.js	cleanup: Require "dangling" commas	2019-11-11 19:25:14 +00:00
extensionSystem.js	cleanup: Require "dangling" commas	2019-11-11 19:25:14 +00:00
focusCaretTracker.js	cleanup: Prefer template strings	2019-07-05 11:32:31 +00:00
grabHelper.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
ibusCandidatePopup.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
iconGrid.js	cleanup: Use JSDoc for documentation comments	2019-11-11 19:25:14 +00:00
inhibitShortcutsDialog.js	cleanup: Require "dangling" commas	2019-11-11 19:25:14 +00:00
kbdA11yDialog.js	cleanup: Use non-deprecated key symbols	2019-11-06 09:42:57 +01:00
keyboard.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
layout.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
lightbox.js	cleanup: Use JSDoc for documentation comments	2019-11-11 19:25:14 +00:00
locatePointer.js	locatePointer: Bind ripples creation to settings	2019-09-09 19:28:18 +00:00
lookingGlass.js	cleanup: Require "dangling" commas	2019-11-11 19:25:14 +00:00
magnifier.js	style: Allow lonely ifs where appropriate	2019-11-11 23:51:17 +00:00
magnifierDBus.js	cleanup: Use JSDoc for documentation comments	2019-11-11 19:25:14 +00:00
main.js	cleanup: Use JSDoc for documentation comments	2019-11-11 19:25:14 +00:00
messageList.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
messageTray.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
modalDialog.js	cleanup: Require "dangling" commas	2019-11-11 19:25:14 +00:00
mpris.js	cleanup: Only omit braces for single-line blocks	2019-11-11 19:25:14 +00:00
notificationDaemon.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
osdMonitorLabeler.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
osdWindow.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
overview.js	style: Allow lonely ifs where appropriate	2019-11-11 23:51:17 +00:00
overviewControls.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
padOsd.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
pageIndicators.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
panel.js	panel: Don't chain up to non-existent parent vfunc	2019-11-14 19:52:34 +01:00
panelMenu.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
pointerA11yTimeout.js	cleanup: Require "dangling" commas	2019-11-11 19:25:14 +00:00
pointerWatcher.js	cleanup: Stop using Mainloop module	2019-09-12 19:09:24 +02:00
popupMenu.js	cleanup: Use JSDoc for documentation comments	2019-11-11 19:25:14 +00:00
remoteSearch.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
ripples.js	cleanup: Require "dangling" commas	2019-11-11 19:25:14 +00:00
runDialog.js	cleanup: Require "dangling" commas	2019-11-11 19:25:14 +00:00
screencast.js	cleanup: Use destructuring for imports from GI	2019-02-09 07:39:20 +01:00
screenShield.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
screenshot.js	cleanup: Require "dangling" commas	2019-11-11 19:25:14 +00:00
scripting.js	cleanup: Use JSDoc for documentation comments	2019-11-11 19:25:14 +00:00
search.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
sessionMode.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
shellDBus.js	cleanup: Use JSDoc for documentation comments	2019-11-11 19:25:14 +00:00
shellEntry.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
shellMountOperation.js	cleanup: Use JSDoc for documentation comments	2019-11-11 19:25:14 +00:00
slider.js	cleanup: Require "dangling" commas	2019-11-11 19:25:14 +00:00
switcherPopup.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
switchMonitor.js	cleanup: Use non-deprecated key symbols	2019-11-06 09:42:57 +01:00
tweener.js	tweener: Use new adjustAnimationTime() helper	2019-08-06 20:50:43 +02:00
unlockDialog.js	cleanup: Use object shorthand where possible	2019-11-11 19:25:14 +00:00
userWidget.js	cleanup: Require "dangling" commas	2019-11-11 19:25:14 +00:00
viewSelector.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
windowAttentionHandler.js	cleanup: Don't shadow variables	2019-11-11 19:25:14 +00:00
windowManager.js	style: Allow lonely ifs where appropriate	2019-11-11 23:51:17 +00:00
windowMenu.js	cleanup: Avoid unnecessary parentheses in arrow functions	2019-09-15 16:02:45 +02:00
workspace.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
workspacesView.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
workspaceSwitcherPopup.js	cleanup: Require "dangling" commas	2019-11-11 19:25:14 +00:00
workspaceThumbnail.js	cleanup: Avoid unnecessary parentheses	2019-11-11 19:25:14 +00:00
xdndHandler.js	cleanup: Require "dangling" commas	2019-11-11 19:25:14 +00:00