gnome-shell/subprojects/extensions-tool/src/command-prefs.c
Florian Müllner 09ed1c533c extensions-tool/prefs: Log D-Bus errors
We currently ignore any error that may occur when calling the
OpenExtensionPrefs D-Bus method. Right now such an error is highly
unlikely, given that we already checked that we are running under
gnome-shell and the extension in question exists and has prefs.

We'll soon make sure that only one dialog is shown at any time,
which is an error that we can realistically expect, so handle that
properly.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4564

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2013>
2021-10-30 21:50:47 +00:00

116 lines
3.1 KiB
C

/* commands-prefs.c
*
* Copyright 2019 Florian Müllner <fmuellner@gnome.org>
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
* SPDX-License-Identifier: GPL-3.0-or-later
*/
#include <glib/gi18n.h>
#include <gio/gio.h>
#include "commands.h"
#include "common.h"
#include "config.h"
static gboolean
launch_extension_prefs (const char *uuid)
{
g_autoptr (GDBusProxy) proxy = NULL;
g_autoptr (GVariant) info = NULL;
g_autoptr (GError) error = NULL;
gboolean has_prefs;
proxy = get_shell_proxy (&error);
if (proxy == NULL)
return FALSE;
info = get_extension_property (proxy, uuid, "hasPrefs");
if (info == NULL)
return FALSE;
has_prefs = g_variant_get_boolean (info);
if (!has_prefs)
{
g_printerr (_("Extension “%s” doesn't have preferences\n"), uuid);
return FALSE;
}
g_dbus_proxy_call_sync (proxy,
"OpenExtensionPrefs",
g_variant_new ("(ssa{sv})", uuid, "", NULL),
0,
-1,
NULL,
&error);
if (error)
{
g_dbus_error_strip_remote_error (error);
g_printerr (_("Failed to open prefs for extension “%s”: %s\n"),
uuid, error->message);
return FALSE;
}
return TRUE;
}
int
handle_prefs (int argc, char *argv[], gboolean do_help)
{
g_autoptr (GOptionContext) context = NULL;
g_autoptr (GError) error = NULL;
g_auto(GStrv) uuids = NULL;
GOptionEntry entries[] = {
{ .long_name = G_OPTION_REMAINING,
.arg_description = "UUID",
.arg = G_OPTION_ARG_STRING_ARRAY, .arg_data = &uuids },
{ NULL }
};
g_set_prgname ("gnome-extensions prefs");
context = g_option_context_new (NULL);
g_option_context_set_help_enabled (context, FALSE);
g_option_context_set_summary (context, _("Opens extension preferences"));
g_option_context_add_main_entries (context, entries, GETTEXT_PACKAGE);
g_option_context_add_group (context, get_option_group());
if (do_help)
{
show_help (context, NULL);
return 0;
}
if (!g_option_context_parse (context, &argc, &argv, &error))
{
show_help (context, error->message);
return 1;
}
if (uuids == NULL)
{
show_help (context, _("No UUID given"));
return 1;
}
else if (g_strv_length (uuids) > 1)
{
show_help (context, _("More than one UUID given"));
return 1;
}
return launch_extension_prefs (*uuids) ? 0 : 2;
}