67b9386b4b
The fullGeometry and the actualGeometry of the WorkspacesDisplay are set from the allocation of the overviews ControlsManager and the WorkspacesDisplay, that means they're only valid after those actors got their allocations during Clutters allocation cycle. Since WorkspacesDisplay._updateWorkspacesViews() is already called while showing/mapping the WorkspacesDisplay, that allocation cycle didn't happen yet and we end up either setting the geometries of the views to null (in case of the fullGeometry) or to something wrong (a 0-sized allocation in case of the actualGeometry). So avoid setting invalid geometries on the views by initializing both the fullGeometry and the actualGeometry to null, and then only updating the geometries of the views after they're set to a correct value. Note that this means we won't correctly animate the overview the first time we open it since the animation depends on the geometries being set, but is being started from show(), which means no allocations have happened yet. In practice this introduces no regression though since before this change we simply used incorrect geometries (see the 0-sized allocation mentioned above) on the initial opening and the animation didn't work either. https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1119 |
||
|---|---|---|
| .gitlab/issue_templates | ||
| .gitlab-ci | ||
| .settings | ||
| data | ||
| docs/reference | ||
| js | ||
| lint | ||
| man | ||
| meson | ||
| po | ||
| src | ||
| subprojects | ||
| tests | ||
| tools | ||
| .eslintrc.yml | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| .gitmodules | ||
| config.h.meson | ||
| COPYING | ||
| gnome-shell.doap | ||
| HACKING.md | ||
| meson_options.txt | ||
| meson.build | ||
| NEWS | ||
| README.md | ||
GNOME Shell
GNOME Shell provides core user interface functions for the GNOME 3 desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience.
For more information about GNOME Shell, including instructions on how to build GNOME Shell from source and how to get involved with the project, see the project wiki.
Bugs should be reported to the GNOME bug tracking system.
Contributing
To contribute, open merge requests at https://gitlab.gnome.org/GNOME/gnome-shell.
Commit messages should follow the GNOME commit message guidelines. We require an URL to either an issue or a merge request in each commit.
License
GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.