![Florian Müllner](/assets/img/avatar_default.png)
Generalizing menu toggling via keyboard in commit 1d58ea25ab6f047 fixed keynav in many places, but it turns out that it also adds unexpected interactions in some cases where the source is not button-like, as for example the entry context menus provided by ShellEntry. Commit e33c68a415 fixed one case, however it is still possible for plain enter/space to unexpectedly trigger the menu if the entry itself doesn't consume the event, which is the case when ClutterText:editable is false. However for a general fix, it makes more sense to consider the source actor's :reactive property and disable toggling menus via keyboard when they cannot be toggled by pointer either - expecting non-editable entries to be non-reactive as well seems like a reasonable assumption, and indeed all our code follows that pattern. https://bugzilla.gnome.org/show_bug.cgi?id=758873
GNOME Shell provides core user interface functions for the GNOME 3 desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience. For more information about GNOME Shell, including instructions on how to build GNOME Shell from source and how to get involved with the project, see: https://wiki.gnome.org/Projects/GnomeShell Bugs should be reported at http://bugzilla.gnome.org against the 'gnome-shell' product. License ======= GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.
Description
Languages
C
49.2%
JavaScript
47.4%
SCSS
1.4%
Meson
0.8%
Python
0.6%
Other
0.4%