Go to file
Jonas Ådahl 5c33fe4a0a appDisplay: Don't start animation from the 'paint' signal
Starting the animation from the actor 'paint' signal has various
unwanted consequences, such as sometimes trigger a
clutter_actor_queue_relayout() during the paint phase. One unwanted
consequence was that an offscreen actor effect was disabled during
painting, meaning the effect would begin being active, but later during
the post-paint processing being disabled. The caused said effect to push
an offscreen framebuffer to the paint context, but then just destroy it
instead of popping it. When this happened, we'd end up trying to operate
on a framebuffer that may had been finalized, or not, depending on the
garbage collector. Sometimes, for some users, this caused a segmentation
fault when trying to pop a matrix from the framebuffer matrix stack.

Deal with this more properly, by using the 'view-loaded' signal to wait
with animation until the view is loaded, as well as using MetaLater to
schedule the start of the animation.

For when a view was signalled to be ready, we're in a state where we can
start animation before the next frame as the layout is ready, but when
not, we have to add back the "hack" where we must wait for one frame for
the target icon positions to be up to date. Do this by adding a
MetaLater IDLE callback that starts the animation *after* the next
frame. This also needs the old 'opacity = 0' work around to not show an
incorrect first frame.

Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2418

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1154
2020-03-30 16:24:31 +00:00
.gitlab/issue_templates gitlab: Add issue templates 2020-01-07 22:42:46 +00:00
.gitlab-ci extensions-app: Move Extensions app to new subproject 2020-03-27 23:33:30 +00:00
.settings Clean out some eclipse artefacts 2019-02-13 04:39:26 +01:00
data data: Update Norwegian OSK layout 2020-03-27 17:07:55 +00:00
docs/reference docs: Fix interface prefix for D-Bus docs 2019-07-25 15:56:20 +02:00
js appDisplay: Don't start animation from the 'paint' signal 2020-03-30 16:24:31 +00:00
lint extensions-app: Move Extensions app to new subproject 2020-03-27 23:33:30 +00:00
man man: Update project website 2018-01-07 21:39:18 +01:00
meson extensionPrefs: Add application icon 2020-02-03 19:03:19 +01:00
po Updated Lithuanian translation 2020-03-29 22:28:04 +03:00
src st/entry: Unset key focus when made unreactive 2020-03-29 22:12:57 +02:00
subprojects extensions-app: Point homepage in metainfo to subproject 2020-03-29 17:49:08 +00:00
tests Use paint and pick context to get framebuffer 2019-12-03 19:07:15 +00:00
tools build: Remove Canberra dependency 2019-01-09 23:09:18 +00:00
.eslintrc.yml lint: Convert eslint JSON to YAML 2019-11-11 23:51:17 +00:00
.gitignore theme: use the fontsize function consistently 2020-01-09 16:43:26 +01:00
.gitlab-ci.yml ci: Build Extensions flatpak bundle 2020-03-27 23:33:30 +00:00
.gitmodules submodules: Replace non-functional git.gnome.org URL by GNOME Gitlab URL 2018-09-25 08:41:30 +02:00
config.h.meson Add check_cloexec_fds debug command 2018-07-30 23:11:41 +00:00
COPYING Changed obsolete FSF postal address. 2014-01-08 04:35:14 +07:00
gnome-shell.doap doap: Add Georges Stavracas as a maintainer 2019-12-18 15:24:38 -03:00
HACKING.md docs: Conform to coding style in HACKING guide 2020-01-06 19:53:21 +01:00
meson_options.txt extensions-app: Move Extensions app to new subproject 2020-03-27 23:33:30 +00:00
meson.build extensions-app: Move Extensions app to new subproject 2020-03-27 23:33:30 +00:00
NEWS Bump version to 3.36.0 2020-03-07 23:30:33 +01:00
README.md README.md: Add contribution section 2019-02-13 20:37:39 +01:00

GNOME Shell

GNOME Shell provides core user interface functions for the GNOME 3 desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience.

For more information about GNOME Shell, including instructions on how to build GNOME Shell from source and how to get involved with the project, see the project wiki.

Bugs should be reported to the GNOME bug tracking system.

Contributing

To contribute, open merge requests at https://gitlab.gnome.org/GNOME/gnome-shell.

Commit messages should follow the GNOME commit message guidelines. We require an URL to either an issue or a merge request in each commit.

License

GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.