brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
5687035c9b
gnome-shell/js/ui
History
Jonas Dreßler 5687035c9b appDisplay: Check instanceof AppIcon using constructor inside the class 
It seems like some recent change (maybe the move to a ClutterActor
subclass for AppIcon) broke the check whether the drag source is an
instance of AppIcon. While the drag source indeed is an AppIcon and
everything else works correctly, the check still returns false, which
breaks the creation of new folders using DnD.

Theoretically it makes sense that this doesn't work, because we're
assigning AppIcon using `var AppIcon =` and that will only get set after
`GObject.register_class()` finished, so accessing `AppIcon` inside that
function seems risky and is probably wrong.

Fix this by comparing to `this.constructor` instead of `AppIcon`, which
works fine and we know for sure exists at this point.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/794
2019-10-31 19:35:37 +00:00
..
components cleanup: Use inheritance for Actor classes instead of composition 2019-10-16 15:26:13 +00:00
status cleanup: Use (un)block_signal_handler() convenience wrapper 2019-10-30 19:40:15 +00:00
accessDialog.js cleanup: Use inheritance for Actor classes instead of composition 2019-10-16 15:26:13 +00:00
altTab.js js: Use Gjs GTypeName computation for all classes 2019-10-29 18:38:35 +00:00
animation.js cleanup: Use inheritance for Actor classes instead of composition 2019-10-16 15:26:13 +00:00
appDisplay.js appDisplay: Check instanceof AppIcon using constructor inside the class 2019-10-31 19:35:37 +00:00
appFavorites.js Update shotwell desktop file name references 2019-10-18 16:50:57 +02:00
audioDeviceSelection.js cleanup: Disambiguate assignments in arrow functions 2019-09-15 16:02:45 +02:00
background.js cleanup: Use inheritance for Actor classes instead of composition 2019-10-16 15:26:13 +00:00
backgroundMenu.js backgroundMenu: Animate menu opening 2019-09-11 23:25:21 +00:00
barLevel.js barLevel: Remove duplicated assignment 2019-08-13 16:35:17 +02:00
boxpointer.js cleanup: Replace signal connections with virtual functions 2019-10-16 15:26:13 +00:00
calendar.js cleanup: Replace signal connections with virtual functions 2019-10-16 15:26:13 +00:00
checkBox.js cleanup: Use inheritance for Actor classes instead of composition 2019-10-16 15:26:13 +00:00
closeDialog.js closeDialog: Fix dialog size when using geometry scaling 2019-10-28 17:30:50 +00:00
ctrlAltTab.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
dash.js cleanup: Use inheritance for Actor classes instead of composition 2019-10-16 15:26:13 +00:00
dateMenu.js cleanup: Replace signal connections with virtual functions 2019-10-16 15:26:13 +00:00
dialog.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
dnd.js dnd: Skip drag target when its acceptDrop() throws an exception 2019-10-22 18:08:10 -07:00
edgeDragAction.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
endSessionDialog.js cleanup: Use inheritance for Actor classes instead of composition 2019-10-16 15:26:13 +00:00
environment.js environment: Use gjs smart GObject GTypeName computation 2019-10-29 18:38:35 +00:00
extensionDownloader.js cleanup: "Only" use two indentation styles for object literals 2019-09-12 23:18:24 +02:00
extensionSystem.js cleanup: Avoid pointless "renames" in destructuring 2019-09-15 16:02:45 +02:00
focusCaretTracker.js cleanup: Prefer template strings 2019-07-05 11:32:31 +00:00
grabHelper.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
ibusCandidatePopup.js cleanup: Replace signal connections with virtual functions 2019-10-16 15:26:13 +00:00
iconGrid.js cleanup: Replace signal connections with virtual functions 2019-10-16 15:26:13 +00:00
inhibitShortcutsDialog.js cleanup: Use consistent style for ternary operator 2019-09-15 13:30:19 +00:00
kbdA11yDialog.js cleanup: Fix wrong indentation 2019-09-15 13:30:19 +00:00
keyboard.js cleanup: Replace signal connections with virtual functions 2019-10-16 15:26:13 +00:00
layout.js cleanup: Replace signal connections with virtual functions 2019-10-16 15:26:13 +00:00
lightbox.js cleanup: Use inheritance for Actor classes instead of composition 2019-10-16 15:26:13 +00:00
locatePointer.js locatePointer: Bind ripples creation to settings 2019-09-09 19:28:18 +00:00
lookingGlass.js js: Use Gjs GTypeName computation for all classes 2019-10-29 18:38:35 +00:00
magnifier.js cleanup: Use inheritance for Actor classes instead of composition 2019-10-16 15:26:13 +00:00
magnifierDBus.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
main.js messageTray: Inherit Notification, Source and NotificationPolicy from GObject 2019-10-16 15:26:12 +00:00
messageList.js js: Use Gjs GTypeName computation for all classes 2019-10-29 18:38:35 +00:00
messageTray.js js: Use Gjs GTypeName computation for all classes 2019-10-29 18:38:35 +00:00
modalDialog.js cleanup: Rename signals/methods that will conflict with Clutter.Actor 2019-10-16 15:26:12 +00:00
mpris.js mpris: Hide notification when !CanPlay, instead of closing player 2019-10-29 19:25:16 +00:00
notificationDaemon.js messageTray: Inherit Notification, Source and NotificationPolicy from GObject 2019-10-16 15:26:12 +00:00
osdMonitorLabeler.js cleanup: Use inheritance for Actor classes instead of composition 2019-10-16 15:26:13 +00:00
osdWindow.js cleanup: Use inheritance for Actor classes instead of composition 2019-10-16 15:26:13 +00:00
overview.js overview: Set searchEntry offscreen-redirected always 2019-10-29 15:41:06 +00:00
overviewControls.js cleanup: Use inheritance for Actor classes instead of composition 2019-10-16 15:26:13 +00:00
padOsd.js js: Use Gjs GTypeName computation for all classes 2019-10-29 18:38:35 +00:00
pageIndicators.js cleanup: Replace signal connections with virtual functions 2019-10-16 15:26:13 +00:00
panel.js panel: Update window section items on title changes 2019-10-28 12:42:28 +01:00
panelMenu.js js: Use Gjs GTypeName computation for all classes 2019-10-29 18:38:35 +00:00
pointerA11yTimeout.js cleanup: Remove left-over imports 2019-09-11 20:59:31 +00:00
pointerWatcher.js cleanup: Stop using Mainloop module 2019-09-12 19:09:24 +02:00
popupMenu.js popupMenu: Don't chain up vfuncs if the parent doesn't implement them 2019-10-28 13:43:55 +00:00
remoteSearch.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
ripples.js cleanup: Disambiguate assignments in arrow functions 2019-09-15 16:02:45 +02:00
runDialog.js cleanup: Avoid unnecessary parentheses in arrow functions 2019-09-15 16:02:45 +02:00
screencast.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
screenShield.js cleanup: Use inheritance for Actor classes instead of composition 2019-10-16 15:26:13 +00:00
screenshot.js js: Use Gjs GTypeName computation for all classes 2019-10-29 18:38:35 +00:00
scripting.js scripting: Disable an eslint warning 2019-09-15 16:02:45 +02:00
search.js search: Drop SearchResultInterface again 2019-10-17 15:56:07 +00:00
sessionMode.js cleanup: Use consistent style for ternary operator 2019-09-15 13:30:19 +00:00
shellDBus.js shellDBus: Don't assume devices have a node 2019-10-07 21:24:13 +00:00
shellEntry.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
shellMountOperation.js js: Use Gjs GTypeName computation for all classes 2019-10-29 18:38:35 +00:00
slider.js cleanup: Replace signal connections with virtual functions 2019-10-16 15:26:13 +00:00
switcherPopup.js cleanup: Replace signal connections with virtual functions 2019-10-16 15:26:13 +00:00
switchMonitor.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
tweener.js tweener: Use new adjustAnimationTime() helper 2019-08-06 20:50:43 +02:00
unlockDialog.js cleanup: Use inheritance for Actor classes instead of composition 2019-10-16 15:26:13 +00:00
userWidget.js js: Use Gjs GTypeName computation for all classes 2019-10-29 18:38:35 +00:00
viewSelector.js cleanup: Use inheritance for Actor classes instead of composition 2019-10-16 15:26:13 +00:00
windowAttentionHandler.js messageTray: Inherit Notification, Source and NotificationPolicy from GObject 2019-10-16 15:26:12 +00:00
windowManager.js windowManager: Always reset window actors when animations are cancelled 2019-10-28 14:28:49 +00:00
windowMenu.js cleanup: Avoid unnecessary parentheses in arrow functions 2019-09-15 16:02:45 +02:00
workspace.js js: Use Gjs GTypeName computation for all classes 2019-10-29 18:38:35 +00:00
workspacesView.js cleanup: Replace signal connections with virtual functions 2019-10-16 15:26:13 +00:00
workspaceSwitcherPopup.js cleanup: Stop using Mainloop module 2019-09-12 19:09:24 +02:00
workspaceThumbnail.js js: Use Gjs GTypeName computation for all classes 2019-10-29 18:38:35 +00:00
xdndHandler.js cleanup: Mark unused (but useful) variables as ignored 2019-07-24 00:28:45 +02:00