Go to file
Jonas Dreßler 4a6f550acb windowManager: Use new mutter API to freeze window actors ourself
We're currently using the hack of telling mutter that our effect is
completed (even though it isn't) in order to unfreeze updates of the
window actor.

This causes a bug with detecting the wl_outputs a window is
visible on, because the MetaWindowActor emits its "effects-completed"
signal too early, making Mutter update the wl_outputs while we're doing
the animation.

Now since meta_wayland_actor_surface_is_on_logical_monitor() uses the
transformed position and size of the MetaSurfaceActor and is being
called right after we setup the animation (but before it actually
starts, that happens at the next paint cycle) it will use a "very wrong"
rectangle: The transformation has been set to move the actor back to its
old position, and while we did already unfreeze updates and called
clutter_actor_set_position() in meta_window_actor_sync_actor_geometry(),
the actual allocation is not updated yet; this makes
clutter_actor_get_transformed_position() return a position including in
the new transformation, but not including the new allocation, and the
rectangle ends up being moved to the next monitor or completely out of
the stage.

To fix this issue properly, we need to decouple unfreezing actor updates
from emitting the "effects-completed" signal, which is now possible with
the new meta_window_actor_freeze() and meta_window_actor_thaw() APIs. So
use those new methods to freeze and thaw actor updates ourselves and
make sure to call shellwm.completed_size_change() only after the
animation has finished.

Mutter MR: https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1250

Fixes https://gitlab.gnome.org/GNOME/mutter/-/issues/513

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1251
2020-06-15 13:12:03 +00:00
.gitlab/issue_templates gitlab: Add issue templates 2020-01-07 22:42:46 +00:00
.gitlab-ci ci: Rebase extension-ci image to F32 2020-04-28 09:04:49 +00:00
.settings Clean out some eclipse artefacts 2019-02-13 04:39:26 +01:00
data workspace: Use invisible guide actor to center overlay title on border 2020-06-14 21:58:47 +00:00
docs/reference docs: Fix interface prefix for D-Bus docs 2019-07-25 15:56:20 +02:00
js windowManager: Use new mutter API to freeze window actors ourself 2020-06-15 13:12:03 +00:00
lint JS: migrate from the global window to globalThis 2020-04-26 19:07:02 -07:00
man man: Update project website 2018-01-07 21:39:18 +01:00
meson extensionPrefs: Add application icon 2020-02-03 19:03:19 +01:00
po Update Turkish translation 2020-06-14 07:52:41 +00:00
src st/entry: Fix leak when copying or cutting text using shortcuts 2020-06-08 15:21:17 +00:00
subprojects Bump version to 3.37.2 2020-06-03 01:29:26 +02:00
tests Remove ClutterAllocationFlags 2020-05-20 15:12:03 +02:00
tools build: Remove Canberra dependency 2019-01-09 23:09:18 +00:00
.eslintrc.yml lint: Convert eslint JSON to YAML 2019-11-11 23:51:17 +00:00
.gitignore Add small gnome-shell-extension-prefs script 2020-04-28 00:06:19 +02:00
.gitlab-ci.yml ci: Rebase extension-ci image to F32 2020-04-28 09:04:49 +00:00
.gitmodules submodules: Replace non-functional git.gnome.org URL by GNOME Gitlab URL 2018-09-25 08:41:30 +02:00
config.h.meson Add check_cloexec_fds debug command 2018-07-30 23:11:41 +00:00
COPYING Changed obsolete FSF postal address. 2014-01-08 04:35:14 +07:00
gnome-shell.doap doap: Add Georges Stavracas as a maintainer 2019-12-18 15:24:38 -03:00
HACKING.md docs: Conform to coding style in HACKING guide 2020-01-06 19:53:21 +01:00
meson_options.txt extensions-app: Move Extensions app to new subproject 2020-03-27 23:33:30 +00:00
meson.build Bump version to 3.37.2 2020-06-03 01:29:26 +02:00
NEWS Bump version to 3.37.2 2020-06-03 01:29:26 +02:00
README.md README.md: Add contribution section 2019-02-13 20:37:39 +01:00

GNOME Shell

GNOME Shell provides core user interface functions for the GNOME 3 desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience.

For more information about GNOME Shell, including instructions on how to build GNOME Shell from source and how to get involved with the project, see the project wiki.

Bugs should be reported to the GNOME bug tracking system.

Contributing

To contribute, open merge requests at https://gitlab.gnome.org/GNOME/gnome-shell.

Commit messages should follow the GNOME commit message guidelines. We require an URL to either an issue or a merge request in each commit.

License

GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.