Go to file
Sebastian Keller 488fb46edf shell/app: Don't move all workspace windows to their startup workspace
Windows from some applications, such as guake, are created as showing on
all workspaces. When these windows are put on the workspaces via
set_workspace_state() during construction, the first time the window is
added to a workspace in the loop triggers the shell app tracker which
then tries to move the window to its startup workspace. This makes the
window unsticky which triggers another set_workspace_state() which
tries to remove the window from all workspaces, but currently it is only
on the first one and then adds it to the startup workspace. Once that is
finished, the first set_workspace_state() continues adding the window
to the remaining workspaces, despite the window now no longer having
on_all_workspaces set to true.

When the window is now unmanaged, the window according to its internal
state is only found on the startup workspace, so it will only be removed
from that. This causes the assertion to fail that checks that the window
is no longer present on any workspace after this.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4720

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2014>
(cherry picked from commit bc32a52108)
2021-11-02 15:38:54 +01:00
.gitlab/issue_templates Add a link to supported releases in the README and bug template 2021-03-03 14:47:20 +00:00
.gitlab-ci ci: Use backend-agnostic meson commands 2021-08-24 08:18:26 +00:00
.settings Clean out some eclipse artefacts 2019-02-13 04:39:26 +01:00
data theme: Fix high-contrast switches 2021-10-14 14:12:10 +00:00
docs/reference docs: Unify on single DocBook version 2020-10-13 03:02:13 +02:00
js environment: Apply autoReverse/repeatCount to all transitions 2021-11-02 15:38:20 +01:00
lint eslint: (Mostly) synchronize configuration with gjs 2021-08-24 08:13:19 +00:00
man man: Update options 2020-12-28 02:25:17 +01:00
meson build: Check sassc errors when generating stylesheets 2021-09-07 12:47:42 +00:00
po Update Persian translation 2021-10-25 20:42:25 +00:00
src shell/app: Don't move all workspace windows to their startup workspace 2021-11-02 15:38:54 +01:00
subprojects Bump version to 41.0 2021-09-19 12:47:55 +02:00
tests util: Add a GNOME version comparison function 2021-02-05 13:41:26 +00:00
tools *: Fix spelling mistakes found by codespell 2020-08-21 18:25:09 +00:00
.eslintrc.yml init: Set console log domain 2021-09-01 14:55:47 +00:00
.gitignore Add small gnome-shell-extension-prefs script 2020-04-28 00:06:19 +02:00
.gitlab-ci.yml ci: Install mutter again on coverity job 2021-10-08 16:17:04 +00:00
.gitmodules submodules: Replace non-functional git.gnome.org URL by GNOME Gitlab URL 2018-09-25 08:41:30 +02:00
.jscheckignore init: Set console log domain 2021-09-01 14:55:47 +00:00
config.h.meson main: Use mallinfo2 when available at build time 2021-07-07 14:44:30 +00:00
COPYING Changed obsolete FSF postal address. 2014-01-08 04:35:14 +07:00
gnome-shell.doap gnome-shell.doap: Make marge-bot a maintainer 2020-11-17 17:29:56 +00:00
HACKING.md *: Fix spelling mistakes found by codespell 2020-08-21 18:25:09 +00:00
meson_options.txt build: Add option to turn off tests 2021-09-07 12:53:47 +00:00
meson.build Revert "st: Only use clutter_actor_invalidate_paint_volume() if the API exists" 2021-11-02 15:38:35 +01:00
NEWS Bump version to 41.0 2021-09-19 12:47:55 +02:00
README.md readme: Change "GNOME 3" to "GNOME" 2021-08-11 14:41:15 +00:00

GNOME Shell

GNOME Shell provides core user interface functions for the GNOME desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience.

For more information about GNOME Shell, including instructions on how to build GNOME Shell from source and how to get involved with the project, see the project wiki.

Bugs should be reported to the GNOME bug tracking system. Please refer to the Schedule wiki page to see the supported versions.

Contributing

To contribute, open merge requests at https://gitlab.gnome.org/GNOME/gnome-shell.

Commit messages should follow the GNOME commit message guidelines. We require an URL to either an issue or a merge request in each commit.

Default branch

The default development branch is main. If you still have a local checkout under the old name, use:

git checkout master
git branch -m master main
git fetch
git branch --unset-upstream
git branch -u origin/main
git symbolic-ref refs/remotes/origin/HEAD refs/remotes/origin/main

License

GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.