45ebb94b33
When cancelling the PolkitAgent session before disconnecting the signal handlers, we receive a "completed" signal where `gained_authorization` is set to FALSE, which means we show an error message inside `_onSessionCompleted()`. This in turn means we show an error message every time we cancel a session. In practice this wasn't really relevant so far since we only destroyed the session when an actual error occurred before. Now that the dialog supports empty passwords, we also call `_destroySession()` when the user changes and no longer has a password set, and in this case we want to cancel the current session without showing an error message. So to fix this, disconnect the signal handlers before cancelling the session, which makes sure we don't receive the last "completed" signal in case we cancelled the session ourselves. This change also allows removing `this._wasDismissed`. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/829 |
||
|---|---|---|
| .. | ||
| __init__.js | ||
| automountManager.js | ||
| autorunManager.js | ||
| keyring.js | ||
| networkAgent.js | ||
| polkitAgent.js | ||
| telepathyClient.js | ||