Read-only mirror of https://gitlab.gnome.org/GNOME/gnome-shell
36f9dcd2bd
dialogContent is set to one of the elements of the list DialogContent,
but not all of those have a checkBoxText property. When logging out (as
opposed to shutting down), this causes a warning:
JS WARNING: [resource:///org/gnome/shell/ui/endSessionDialog.js
763]: reference to undefined property "checkBoxText"
(The line number corresponds to this line in 3.28.3.)
The warning is apparently not triggered if the undefined property is
used as part of a boolean expression:
gjs> var x = {};
gjs> x.a;
typein:2:1 strict warning: reference to undefined property "a"
gjs> if (x.b) { log('oh no'); }
gjs> x.c || ''
""
_setCheckBoxLabel() just checks the truthiness of its 'text' argument,
and the empty string is false-y, so passing '' rather than undefined has
no functional effect.
(cherry picked from commit
|
||
|---|---|---|
| .settings | ||
| browser-plugin | ||
| data | ||
| docs/reference | ||
| js | ||
| man | ||
| meson | ||
| po | ||
| src | ||
| subprojects | ||
| tests | ||
| tools/build | ||
| .gitignore | ||
| .gitmodules | ||
| .project | ||
| AUTHORS | ||
| config.h.meson | ||
| COPYING | ||
| gnome-shell.doap | ||
| HACKING | ||
| MAINTAINERS | ||
| meson_options.txt | ||
| meson.build | ||
| NEWS | ||
| README | ||
GNOME Shell provides core user interface functions for the GNOME 3 desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience. For more information about GNOME Shell, including instructions on how to build GNOME Shell from source and how to get involved with the project, see: https://wiki.gnome.org/Projects/GnomeShell Bugs should be reported at http://bugzilla.gnome.org against the 'gnome-shell' product. License ======= GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.