brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Read-only mirror of https://gitlab.gnome.org/GNOME/gnome-shell
13,356 Commits 180 Branches 237 Tags 70 MiB
C 49.2%
JavaScript 47.4%
SCSS 1.4%
Meson 0.8%
Python 0.6%
Other 0.4%
1cc766d636
Go to file
Marco Trevisan (Treviño) 1cc766d636 ibusManager, inputMethod: Cancel async ibus calls chain on disconnect 
The shell tries to spawn the ibus daemon on startup if unavailable, however
as per commit 8adfc5b1 we also force restarting it once the X11 server is
available.
Unfortunately this could cause a race if we disconnect while we were already
connected to an ibus daemon, but still in the process of going through the
various nested calls.
In fact the ::disconnect callback didn't stop any further async ibus call
that, even if failing, would have eventually triggered the emission of a
'ready' signal and to the Keyboard's callback, leading under X11 to a full
grab owned by ibus daemon.

In order to avoid this and keep control of the calls order, use in both
IbusManager and InputMethod a cancellable that is setup before connecting to
the bus, and that is cancelled on disconnection.
Then handle the finish() calls properly, using try/catch to validate the
returned value, taking in account the potential error and just not
proceeding in case of cancellation.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/issues/1712
2019-10-02 18:19:53 +02:00
.gitlab-ci ci: Disable MR handling for now 2019-09-12 23:18:27 +02:00
.settings Clean out some eclipse artefacts 2019-02-13 04:39:26 +01:00
data renameFolderMenu: Use a custom menu item inheriting from PopupBaseMenuItem 2019-09-20 15:53:42 +00:00
docs/reference docs: Fix interface prefix for D-Bus docs 2019-07-25 15:56:20 +02:00
js ibusManager, inputMethod: Cancel async ibus calls chain on disconnect 2019-10-02 18:19:53 +02:00
lint lint: Drop extra ignored nodes in legacy config 2019-09-15 13:30:19 +00:00
man man: Update project website 2018-01-07 21:39:18 +01:00
meson build: Run postinstall script where necessary 2018-04-09 19:19:33 +00:00
po Updated Danish translation 2019-10-02 05:35:36 +02:00
src shell-util: Handle NULL from meta_window_get_image() 2019-09-25 14:34:27 +00:00
subprojects gvc: Update submodule to up-to-date version 2019-02-28 21:59:08 +01:00
test Add convert_xml test 2019-03-04 20:55:15 +00:00
tests util: Handle trailing LTR/RTL markers in URLs 2019-09-16 20:41:47 +00:00
tools build: Remove Canberra dependency 2019-01-09 23:09:18 +00:00
.eslintrc.json lint: Tweak the whitelist of globals 2019-07-12 16:01:07 +00:00
.gitignore Ignore '.vscode' folder for users of that editor 2019-04-02 17:37:31 +00:00
.gitlab-ci.yml ci: Turn on -Werror 2019-09-10 17:51:02 +00:00
.gitmodules submodules: Replace non-functional git.gnome.org URL by GNOME Gitlab URL 2018-09-25 08:41:30 +02:00
cldr2json.py Fix override for fr-CA 2019-03-04 20:55:15 +00:00
config.h.meson Add check_cloexec_fds debug command 2018-07-30 23:11:41 +00:00
COPYING Changed obsolete FSF postal address. 2014-01-08 04:35:14 +07:00
gnome-shell.doap Replace Bugzilla by Gitlab URL in DOAP file 2018-12-15 23:26:54 +01:00
HACKING.md docs: Update animation section 2019-08-07 18:40:49 +02:00
meson_options.txt extensions-tool: Start import 2019-08-21 18:28:02 +02:00
meson.build Bump version to 3.34.0 2019-09-09 19:21:11 +00:00
NEWS Bump version to 3.34.0 2019-09-09 19:21:11 +00:00
README.md README.md: Add contribution section 2019-02-13 20:37:39 +01:00
README.mdwn Add basic documentation 2019-03-04 20:55:15 +00:00

README.md

GNOME Shell

GNOME Shell provides core user interface functions for the GNOME 3 desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience.

For more information about GNOME Shell, including instructions on how to build GNOME Shell from source and how to get involved with the project, see the project wiki.

Bugs should be reported to the GNOME bug tracking system.

Contributing

To contribute, open merge requests at https://gitlab.gnome.org/GNOME/gnome-shell.

Commit messages should follow the GNOME commit message guidelines. We require an URL to either an issue or a merge request in each commit.

License

GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.