17726abb0a
get_secrets_keyring_cb() contained an optimization (copied over from nm-applet) that avoided a D-Bus round-trip when NetworkManager sent secrets hints that were not satisified by the user. This code did not properly handle empty hints though, and proceeded to always request new secrets whenever empty hints were sent. Remove this code entirely since the complexity is not worth it (per Jasper). Second, get_secrets_keyring_cb() was mishandling VPN secrets which were marked as "always ask". Because the VPN secrets are not GObject properties because they cannot be pre-defined, they are passed in a hash table that is a GObject property marked 'secret'. Unfortunately, that means that the shell agent cannot determine their secret flags. But since the VPN plugin auth dialogs have much better information about what's required than the shell agent does, always ask the VPN auth dialogs to handle the secrets requests after grabbing any that already exist from the keyring. This is also what nm-applet does. https://bugzilla.gnome.org/show_bug.cgi?id=719815
GNOME Shell provides core user interface functions for the GNOME 3 desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience. For more information about GNOME Shell, including instructions on how to build GNOME Shell from source and how to get involved with the project, see: http://live.gnome.org/GnomeShell Bugs should be reported at http://bugzilla.gnome.org against the 'gnome-shell' product. License ======= GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.