3d8b866a9d
The code to highlight matches did not properly escape the passed in text as for markup before adding its highlighting markup. This lead to some search result descriptions not showing up, because their descriptions contained characters, such as "<", that would have to be escaped when used in markup or otherwise lead to invalid markup. To work around this some search providers wrongly started escaping the description on their end before sending them to gnome-shell. This lead to another issue. Now if the highlighter was trying to highlight the term "a", and the escaped description contained "'", the "a" in that would be considered a match and surrounded by "<b></b>". This however would also generate invalid markup, again leading to an error and the description not being shown. Fix this by always escaping the passed in string before applying the highlights in such a way that there are no matches within entities. This also means that search providers that escaped their description strings will now show up with the markup syntax. This will have to be fixed separately in the affected search providers. Fixes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4791 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2033> |
||
|---|---|---|
| .. | ||
| config.js.in | ||
| extensionUtils.js | ||
| fileUtils.js | ||
| gnomeSession.js | ||
| history.js | ||
| ibusManager.js | ||
| inputMethod.js | ||
| introspect.js | ||
| jsParse.js | ||
| keyboardManager.js | ||
| loginManager.js | ||
| meson.build | ||
| modemManager.js | ||
| objectManager.js | ||
| params.js | ||
| parentalControlsManager.js | ||
| permissionStore.js | ||
| smartcardManager.js | ||
| systemActions.js | ||
| util.js | ||
| weather.js | ||