brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
114d8d0aba
gnome-shell/src
History
Dan Williams 17726abb0a NetworkAgent: handle empty hints and VPN secrets correctly 
get_secrets_keyring_cb() contained an optimization (copied over from
nm-applet) that avoided a D-Bus round-trip when NetworkManager sent
secrets hints that were not satisified by the user.  This code did
not properly handle empty hints though, and proceeded to always
request new secrets whenever empty hints were sent.  Remove this
code entirely since the complexity is not worth it (per Jasper).

Second, get_secrets_keyring_cb() was mishandling VPN secrets which
were marked as "always ask".  Because the VPN secrets are not GObject
properties because they cannot be pre-defined, they are passed in
a hash table that is a GObject property marked 'secret'.  Unfortunately,
that means that the shell agent cannot determine their secret flags.
But since the VPN plugin auth dialogs have much better information
about what's required than the shell agent does, always ask the VPN
auth dialogs to handle the secrets requests after grabbing any that
already exist from the keyring.  This is also what nm-applet does.

https://bugzilla.gnome.org/show_bug.cgi?id=719815
2013-12-13 16:23:24 -06:00
..
calendar-server
gvc@e14dbe8aa6 Update gvc 2013-09-17 11:54:44 -04:00
hotplug-sniffer
st st-scroll-view: Fix style 2013-12-11 20:36:44 -05:00
tray
data-to-c.pl
gnome-shell-extension-prefs.in
gnome-shell-extension-tool.in
gnome-shell-perf-tool.in
gnome-shell-plugin.c bluetooth: Remove GnomeBluetoothApplet hacks 2013-11-26 18:53:18 +01:00
gtkactionmuxer.c
gtkactionmuxer.h
gtkactionobservable.c
gtkactionobservable.h
gtkactionobserver.c
gtkactionobserver.h
gtkmenutracker.c
gtkmenutracker.h
gtkmenutrackeritem.c
gtkmenutrackeritem.h
main.c bluetooth: Remove GnomeBluetoothApplet hacks 2013-11-26 18:53:18 +01:00
Makefile-calendar-server.am build: Remove -DG_DISABLE_DEPRECATED 2013-08-15 16:06:54 -04:00
Makefile-hotplug-sniffer.am build: Remove -DG_DISABLE_DEPRECATED 2013-08-15 16:06:54 -04:00
Makefile-st.am build: Do not ship generated source-files in tarball 2013-10-30 23:29:45 +01:00
Makefile-tray.am build: Do not ship generated source-files in tarball 2013-10-30 23:29:45 +01:00
Makefile.am bluetooth: Remove GnomeBluetoothApplet hacks 2013-11-26 18:53:18 +01:00
run-js-test.c bluetooth: Remove GnomeBluetoothApplet hacks 2013-11-26 18:53:18 +01:00
shell-app-private.h appDisplay: Use the desktop file index for app searching 2013-11-14 14:28:52 -05:00
shell-app-system-private.h
shell-app-system.c appDisplay: Use the desktop file index for app searching 2013-11-14 14:28:52 -05:00
shell-app-system.h appDisplay: Use the desktop file index for app searching 2013-11-14 14:28:52 -05:00
shell-app-usage.c appDisplay: Use the desktop file index for app searching 2013-11-14 14:28:52 -05:00
shell-app-usage.h appDisplay: Use the desktop file index for app searching 2013-11-14 14:28:52 -05:00
shell-app.c shell-app: Track all application windows 2013-12-07 10:10:06 +01:00
shell-app.h app-system: Remove use of gnome-menus internally 2013-11-02 20:12:37 -04:00
shell-embedded-window-private.h
shell-embedded-window.c embedded-window: Set as app-paintable to workaround opaque region issues 2013-09-06 16:28:41 -04:00
shell-embedded-window.h
shell-enum-types.c.in
shell-enum-types.h.in
shell-generic-container.c
shell-generic-container.h
shell-global-private.h
shell-global.c shell_global_reexec_self: add support for OpenBSD 2013-10-31 11:46:59 +01:00
shell-global.h remove direct access to jsapi 2013-10-30 07:44:34 +11:00
shell-gtk-embed.c shell-gtk-embed: Make the MetaWindowActor for a tray icon unreactive 2013-08-21 16:53:05 -04:00
shell-gtk-embed.h
shell-invert-lightness-effect.c
shell-invert-lightness-effect.h
shell-js.cpp port shell-js to c++ 2013-10-30 07:44:34 +11:00
shell-js.h shell-js: fix incorrect G_BEGIN_DECLS in header 2013-10-15 09:21:59 +11:00
shell-keybinding-modes.h
shell-keyring-prompt.c shell: Make KeyringPrompt.cancel() callable from signal handlers 2013-09-23 13:32:17 +02:00
shell-keyring-prompt.h
shell-menu-tracker.c
shell-menu-tracker.h
shell-mount-operation.c
shell-mount-operation.h
shell-network-agent.c NetworkAgent: handle empty hints and VPN secrets correctly 2013-12-13 16:23:24 -06:00
shell-network-agent.h network-agent: Remove prototype of unused function 2013-07-02 14:17:38 -04:00
shell-perf-helper.c
shell-perf-log.c
shell-perf-log.h
shell-polkit-authentication-agent.c
shell-polkit-authentication-agent.h
shell-recorder-src.c
shell-recorder-src.h
shell-recorder.c ShellRecorder: update to use MetaCursorTracker 2013-08-19 16:14:12 +02:00
shell-recorder.h
shell-screenshot.c ShellScreenshot: replace XFixes usage with MetaCursorTracker 2013-08-19 16:14:12 +02:00
shell-screenshot.h
shell-secure-text-buffer.c
shell-secure-text-buffer.h
shell-slicer.c popupMenu: Simplify allocation code 2013-07-15 12:34:22 -04:00
shell-slicer.h
shell-stack.c
shell-stack.h
shell-tp-client.c
shell-tp-client.h
shell-tray-icon.c Implementing building two separate binaries for x11 and wayland 2013-08-27 09:46:01 +02:00
shell-tray-icon.h
shell-tray-manager.c
shell-tray-manager.h
shell-util.c appDisplay: Use the desktop file index for app searching 2013-11-14 14:28:52 -05:00
shell-util.h appDisplay: Use the desktop file index for app searching 2013-11-14 14:28:52 -05:00
shell-window-tracker-private.h
shell-window-tracker.c shell-app: Track all application windows 2013-12-07 10:10:06 +01:00
shell-window-tracker.h
shell-wm-private.h Add a confirmation dialog for display changes 2013-08-20 12:03:13 +02:00
shell-wm.c Add a confirmation dialog for display changes 2013-08-20 12:03:13 +02:00
shell-wm.h Add a confirmation dialog for display changes 2013-08-20 12:03:13 +02:00