0d259d62b2
The NMConnectionSection class is used - surprise - to manage a list of related connections. And while the presentation of VPN items is slightly different from connections associated with devices (switches vs. ornaments), it makes perfect sense for the VPN section to share the nitty-gritty with the base class. But… Right now it is perfectly fine for NMConnectionSection to be used both as a child element in a device section, and as toplevel item of the VPN section. Any nesting of sections is entirely transparent to the user, and all connection sections appear as submenu items in the toplevel menu. That won't work for quick settings. There's no PopoverMenuSection that allows invisible grouping, so adding items dynamically would either need to happen at the end, or require some tricky cross-component code to impose a particular order. And last but not least, quick toggles are very much unsuited for a potentially large number of items. The whole point is to provide quick direct access to system features, not to compete with menus over the number of items they can hold. That is, we need to get from the current state where each device appears as a toplevel item, to a state where we have one quick toggle for each device type plus one for VPN. The decoupled VPN section still behaves largely as it did as a subclass, with the notable difference that it no longer uses a submenu item, so all VPN connections now appear at the toplevel. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2407>
GNOME Shell
GNOME Shell provides core user interface functions for the GNOME desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience.
For more information about GNOME Shell, including instructions on how to build GNOME Shell from source and how to get involved with the project, see the project wiki.
Bugs should be reported to the GNOME bug tracking system. Please refer to the Schedule wiki page to see the supported versions.
Contributing
To contribute, open merge requests at https://gitlab.gnome.org/GNOME/gnome-shell.
Commit messages should follow the GNOME commit message guidelines. We require an URL to either an issue or a merge request in each commit.
Default branch
The default development branch is main. If you still have a local
checkout under the old name, use:
git checkout master
git branch -m master main
git fetch
git branch --unset-upstream
git branch -u origin/main
git symbolic-ref refs/remotes/origin/HEAD refs/remotes/origin/main
License
GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.